[BUGFIX] Avoid undefined array key when using an offline workspace - #29
Open
brotkrueml wants to merge 1 commit into
Open
[BUGFIX] Avoid undefined array key when using an offline workspace#29brotkrueml wants to merge 1 commit into
brotkrueml wants to merge 1 commit into
Conversation
The following error is thrown with PHP 8 when accessing the page properties
in an offline workspace:
PHP Warning: Trying to access array offset on value of type bool in /var/www/html/vendor/haassie/page-speed-insights/Classes/Utility/PageSpeedInsightsUtility.php line 190
Additionally, a superfluous call in method getLastScore() has been removed
as the variables are not used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following error is thrown with PHP 8 when accessing the page properties in an offline workspace:
Additionally, a superfluous call in method getLastScore() has been removed as the variables are not used.