changed questionformid to questionformref and adjusted clone #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoexue
requested review from
BlazingAsher,
Lindsay-X,
dtpu and
ja-der
and removed request for
BlazingAsher and
dtpu
dtpu
requested changes
Jan 20, 2026
Contributor
dtpu
left a comment
dtpu
left a comment
There was a problem hiding this comment.
remember to regenerate your migrations on top of the changes in main! Also, I don't see anything with the formName in your services. Could you also add that stuff? (e.x. formName should be provided by the user on the cloneForm route)
| srcQuestions.map((q) => ({ | ||
| formQuestionId: crypto.randomUUID(), | ||
| srcQuestions.map((q, index) => ({ | ||
| formQuestionRef: newQuestionRefs[index], // Use provided new ref |
Contributor
There was a problem hiding this comment.
lets not do this, would make more sense to keep the formQuestionRefs from the previous form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change name formQuestionId -> formQuestionRef
Cloning form api now uses formQuestionRef(s) that is provided. Adjusted tests accordingly.