Require a second factor to enable 2FA #12441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YodaLightsabr
approved these changes
Dec 22, 2025
Contributor
YodaLightsabr
left a comment
YodaLightsabr
left a comment
There was a problem hiding this comment.
Code looks good, please fix tests though
Comment on lines
54
to
+56
| user.update!(phone_number_verified: true) | ||
| user.update!(use_sms_auth: true) | ||
| user.update!(use_two_factor_authentication: true) |
Contributor
There was a problem hiding this comment.
Can we pass these in create?
Comment on lines
94
to
+96
| user.update!(phone_number_verified: true) | ||
| user.update!(use_sms_auth: true) | ||
| user.update!(use_two_factor_authentication: true) |
Contributor
There was a problem hiding this comment.
Can we pass these in create?
|
|
||
| it "can be enabled with SMS auth" do | ||
| user = create(:user, phone_number: "+18556254225", phone_number_verified: true) | ||
| user.update!(use_sms_auth: true) |
Contributor
There was a problem hiding this comment.
Can we pass this in create?
Member
Author
There was a problem hiding this comment.
No because of callbacks in the User model, any time the phone number is changed, use_sms_auth becomes false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12419. Also adds a test for this!