Skip to content

Polish reactions#208

Draft
moreal wants to merge 1 commit intohackers-pub:mainfrom
moreal:reactions-polishing
Draft

Polish reactions#208
moreal wants to merge 1 commit intohackers-pub:mainfrom
moreal:reactions-polishing

Conversation

@moreal
Copy link
Contributor

@moreal moreal commented Mar 1, 2026

Note

By priority, I leave this pull request as draft temporarily. I'll work more on this pull request.

Changes

You can see possible reactions by hover on it, without clicking the React button.

image

TODO

  • Correct reactions stats.
  • Show real reactions instead heart icon.

Replace DropdownMenu with Kobalte HoverCard for the emoji reaction
popover, which natively supports hover-based open/close with safe area
between trigger and content.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 1, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience for viewing post reactions by transitioning from a click-based dropdown interaction to a more intuitive hover-based display. This change allows users to quickly preview available reactions without needing to commit to a click, streamlining the interaction flow.

Highlights

  • UI Component Change: Replaced the DropdownMenu component with a HoverCard component for displaying post reactions, allowing users to see reactions on hover instead of click.
  • New UI Component: Introduced a new HoverCard UI component, built using @kobalte/core/hover-card primitives, to provide reusable hover card functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • web-next/src/components/PostControls.tsx
    • Replaced DropdownMenu, DropdownMenuContent, and DropdownMenuTrigger imports with HoverCard, HoverCardContent, and HoverCardTrigger.
    • Updated the reaction display mechanism from a DropdownMenu to a HoverCard, including openDelay and closeDelay properties for the hover interaction.
  • web-next/src/components/ui/hover-card.tsx
    • Added a new HoverCard component file, implementing HoverCardPrimitive.Root, HoverCardPrimitive.Trigger, and HoverCardPrimitive.Content from @kobalte/core/hover-card.
Activity
  • The pull request is currently in draft status, indicating that the author intends to continue working on it.
  • The author has provided a screenshot demonstrating the new hover-based reaction display.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the click-to-open DropdownMenu for reactions with a HoverCard that appears on hover, improving user experience by making reactions more accessible. A new hover-card.tsx component has been added for this purpose. The implementation is clean and follows existing patterns.

My review includes feedback based on the repository style guide, specifically regarding the naming convention for component files (line 59).

@@ -0,0 +1,38 @@
import type { ValidComponent } from "solid-js";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the repository style guide, files containing components should use PascalCase for their names. Please rename this file to HoverCard.tsx to align with the convention.

References
  1. Line 59: Files with components use PascalCase (Button.tsx) (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant