-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapt ValidatedTextField to accept custom validation functions #1789
base: development
Are you sure you want to change the base?
adapt ValidatedTextField to accept custom validation functions #1789
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angela-lee1 it looks like one of your changes caused a change on styling as well.
@angela-lee1 Just checking in on this PR! Were you able to address the styling concerns that @pluto-bell mentioned in her review above? |
@JackHaeg will get this resolved before next team meeting. Sorry. |
No problem, @angela-lee1! Thanks in advance for working on this! |
Hi @angela-lee1 Just checking in on this PR :) When you have a moment, can you please provide an update with the following information:
|
@JackHaeg I am terribly sorry. I don't have any blockers. I will get it done by this Friday at the end of the day. I made and pushed up the changes. I might need Trillium's help with the merge conflict. |
Hi @angela-lee1 No worries at all - seriously!! Thanks so much for confirming and for making these updates to the PR :) |
Fixes #1484
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
image
Visuals after changes are applied
[image](

)