Skip to content

Conversation

caz002
Copy link
Member

@caz002 caz002 commented Oct 11, 2025

Fixes #8352

What changes did you make?

  • removed "Languages" and "Tools" filters on Homepage, by transferring the items in "Languages" and "Tools" to "Languages/Technologies/Tools"

Why did you make the changes (we will use this info to test)?

  • To simplify the project filters layout by removing/combining filters
  • Match layout of Homepage filters with Project page

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Screenshot 2025-10-11 at 12 22 45 PM
Visuals after changes are applied Screenshot 2025-10-11 at 12 23 03 PM

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b caz002-remove-language-tool-filters-8352 gh-pages
git pull https://github.com/caz002/website.git remove-language-tool-filters-8352

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Medium P-Feature: Home page https://www.hackforla.org/ size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 11, 2025
@kdaca19xx kdaca19xx self-requested a review October 12, 2025 17:08
@kdaca19xx
Copy link
Member

kdaca19xx commented Oct 12, 2025

Availability - after 11am (pacific)
ETA - 10/15

Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way to go, caz001!

Things Done Well

  • The pull request was done with the correct branch.

  • There's a linked issue. I read/understood it.

  • Your code edit in the Files Changed tab looks good.

  • Using Docker, I can see the deletion of the Languages section and the Tools section in Filters sidebar.

Suggestions

  • none

I'd like to approve this PR.

@lc1715 lc1715 self-requested a review October 16, 2025 20:16
@lc1715
Copy link
Member

lc1715 commented Oct 16, 2025

Review ETA: 10/16/25
Availability: 1-5 PM Mon-Fri

Copy link
Member

@lc1715 lc1715 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @caz002, great job working on this issue!

  • The PR was done with the correct branch and linked issue
  • The changes made are applicable to the issue and filters work as intended
  • The source code looks great

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium P-Feature: Home page https://www.hackforla.org/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Status: PRs ✅ waiting for merge team

Development

Successfully merging this pull request may close these issues.

Update Homepage: Remove Languages and Tools Categories

3 participants