Skip to content

Conversation

@Mykola-Lopushenko
Copy link
Member

@Mykola-Lopushenko Mykola-Lopushenko commented Oct 14, 2025

Fixes #8314

What changes did you make?

  • Clarified the typical order of roles in the leadership list
  • Improved instructions for verifying changes locally
  • Added project page reference as [^3] and adjusted references

Why did you make the changes (we will use this info to test)?

  • To make the template clearer and easier for contributors to follow
  • To ensure consistency when adding/updating leadership members

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

  • No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Mykola-Lopushenko-edit-profile-template-8314 gh-pages
git pull https://github.com/Mykola-Lopushenko/website.git edit-profile-template-8314

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) Ready for Prioritization size: 0.5pt Can be done in 3 hours or less labels Oct 14, 2025
@kelwilson kelwilson self-requested a review October 16, 2025 02:07
Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue.


Done Correctly

  • The merge from and to branches have been correctly set.
  • The issue has been correctly linked.
  • The whats and whys in the pull request description have been filled out.
  • The CodeQL alerts have been correctly checked off.
  • Code changes for project-profile-leader-updates---add.md have been correctly made.
  • In the issue, you've correctly assigned yourself.
  • In the issue, the project and its status has been correctly assigned.
  • In the issue, action items have correctly been checked off.

Changes that need to be made

  • In the pull request title, please remove the issue number 8314. See contributing instructions on explaining this. You can also specify "issue template" instead of "template" for clarity.
  • Please remove the reviewers that you added. The suggested reviewers that GitHub gives are randomly shown volunteers in the website team. Most team members are inactive. Please only add individuals that you have personally asked.
  • Changes in guides-team.md should not be included in this pull request, as it is irrelevant. Please remove this from your pull request by making a new commit with the file added back in. It looks like you need to update your local repo or your fork of the website repo on GitHub.

Optional recommendations

  • In the issue, you didn't give your availability and ETA. You can put that in now for completeness, but you should get into the habit of giving them after you've assigned yourself, even if you are able to complete the work in a few hours.

  • In the What changes did you make? part of your pull request description, for the first line,

    Updated .github/ISSUE_TEMPLATE/project-profile-leader-updates---add.md

    , stating this is unnecessary as reviewers can easily see what files have changed.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Oct 16, 2025
Copy link
Member

@kelwilson kelwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Mykola-Lopushenko , Thanks for working on this issue

Things Done Well

  • The pull request was made into the correct branch "hackforla:gh-pages"
  • The issue was correctly linked, keeping the workflow organized.
  • The required edits from the issue were properly implemented.
  • The changes were well executed and didn’t break the website.

Changes Required

  • In the pull request title, please remove the issue number #8314.
  • Remove the reviewers that you added.

See the original comment for reference: [ ] ( #8374 (review) )


Overall, this is a clean and thoughtful contribution. Thanks for contributing 😇!

@Mykola-Lopushenko Mykola-Lopushenko changed the title Update Project Profile Leader template (#8314) Update Project Profile Leader issue template Oct 19, 2025
@Mykola-Lopushenko
Copy link
Member Author

Mykola-Lopushenko commented Oct 19, 2025

Thank you for working on this issue.

Done Correctly

  • The merge from and to branches have been correctly set.
  • The issue has been correctly linked.
  • The whats and whys in the pull request description have been filled out.
  • The CodeQL alerts have been correctly checked off.
  • Code changes for project-profile-leader-updates---add.md have been correctly made.
  • In the issue, you've correctly assigned yourself.
  • In the issue, the project and its status has been correctly assigned.
  • In the issue, action items have correctly been checked off.

Changes that need to be made

  • In the pull request title, please remove the issue number 8314. See contributing instructions on explaining this. You can also specify "issue template" instead of "template" for clarity.
  • Please remove the reviewers that you added. The suggested reviewers that GitHub gives are randomly shown volunteers in the website team. Most team members are inactive. Please only add individuals that you have personally asked.
  • Changes in guides-team.md should not be included in this pull request, as it is irrelevant. Please remove this from your pull request by making a new commit with the file added back in. It looks like you need to update your local repo or your fork of the website repo on GitHub.

Optional recommendations

  • In the issue, you didn't give your availability and ETA. You can put that in now for completeness, but you should get into the habit of giving them after you've assigned yourself, even if you are able to complete the work in a few hours.

  • In the What changes did you make? part of your pull request description, for the first line,

    Updated .github/ISSUE_TEMPLATE/project-profile-leader-updates---add.md

    , stating this is unnecessary as reviewers can easily see what files have changed.

Thanks for the feedback!
I've updated the PR:

  • Removed issue number from the title
  • Restored guides-team.md file

Let me know if anything else is needed.

Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Copy link
Member

@kelwilson kelwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Mykola-Lopushenko,
Thanks for taking the time to work on this issue.

Things Done Well

  • All required changes have been correctly implemented.

Suggestions
None, everything looks great!


Thanks for contributing! Happy coding 😇

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Oct 21, 2025
@myronchen-git myronchen-git modified the milestone: x. Technical debt Oct 22, 2025
@ryanfkeller
Copy link
Member

Thanks @Mykola-Lopushenko for the PR and updates, and @myronchen-git and @kelwilson for the reviews. Agreed with all above, merging!

@ryanfkeller ryanfkeller merged commit 2f0713e into hackforla:gh-pages Oct 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Edits to the "Project Profile Leader Updates- Add" template

5 participants