-
-
Notifications
You must be signed in to change notification settings - Fork 845
Update Project Profile Leader issue template #8374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile Leader issue template #8374
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this issue.
Done Correctly
- The merge from and to branches have been correctly set.
- The issue has been correctly linked.
- The whats and whys in the pull request description have been filled out.
- The CodeQL alerts have been correctly checked off.
- Code changes for
project-profile-leader-updates---add.mdhave been correctly made. - In the issue, you've correctly assigned yourself.
- In the issue, the project and its status has been correctly assigned.
- In the issue, action items have correctly been checked off.
Changes that need to be made
- In the pull request title, please remove the issue number 8314. See contributing instructions on explaining this. You can also specify "issue template" instead of "template" for clarity.
- Please remove the reviewers that you added. The suggested reviewers that GitHub gives are randomly shown volunteers in the website team. Most team members are inactive. Please only add individuals that you have personally asked.
- Changes in
guides-team.mdshould not be included in this pull request, as it is irrelevant. Please remove this from your pull request by making a new commit with the file added back in. It looks like you need to update your local repo or your fork of thewebsiterepo on GitHub.
Optional recommendations
-
In the issue, you didn't give your availability and ETA. You can put that in now for completeness, but you should get into the habit of giving them after you've assigned yourself, even if you are able to complete the work in a few hours.
-
In the What changes did you make? part of your pull request description, for the first line,
Updated
.github/ISSUE_TEMPLATE/project-profile-leader-updates---add.md, stating this is unnecessary as reviewers can easily see what files have changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @Mykola-Lopushenko , Thanks for working on this issue
Things Done Well
- The pull request was made into the correct branch "hackforla:gh-pages"
- The issue was correctly linked, keeping the workflow organized.
- The required edits from the issue were properly implemented.
- The changes were well executed and didn’t break the website.
Changes Required
- Please, implement the following updates requested by @myronchen-git
- In the pull request title, please remove the issue number #8314.
- Remove the reviewers that you added.
See the original comment for reference: [ ] ( #8374 (review) )
Overall, this is a clean and thoughtful contribution. Thanks for contributing 😇!
Thanks for the feedback!
Let me know if anything else is needed. |
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
kelwilson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @Mykola-Lopushenko,
Thanks for taking the time to work on this issue.
Things Done Well
- All required changes have been correctly implemented.
Suggestions
None, everything looks great!
Thanks for contributing! Happy coding 😇
|
Thanks @Mykola-Lopushenko for the PR and updates, and @myronchen-git and @kelwilson for the reviews. Agreed with all above, merging! |
Fixes #8314
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging