Conversation
…nd add nint/nuint support Use MemberType.SpecialType instead of runtime type pattern matching in EmitDefaultValue(), because Roslyn may box numeric default values as int regardless of the parameter type (fixes #166). Also add nint/nuint formatters and register them in BuiltinResolver. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hadashiA
force-pushed
the
fix/source-generator-numeric-default-values
branch
from
daf800b to
f388a2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EmitDefaultValue()now usesMemberType.SpecialTypeinstead of runtime type pattern matching, because Roslyn may box numeric default values asintregardless of the actual parameter type (e.g.ushort address = 0was emitted asvar __Address__ = 0instead ofvar __Address__ = (ushort)0)short,sbyte,char,long, and enum typesnint/nuintformatter support (NativeIntFormatter,NativeUIntFormatterand their nullable variants)Test plan
WithNumericDefaultValuestest type withushort = 0,short = 0,sbyte = 0default paramsDeserialize_NumericDefaultValuesandDeserialize_NumericDefaultValues_PartialOverridetestsSerializeDeserialize_NativeIntandSerializeDeserialize_NativeUInttests🤖 Generated with Claude Code