Fix buffer overflow when serializing strings longer than 2048 chars#173
Merged
Fix buffer overflow when serializing strings longer than 2048 chars#173
Conversation
ExpandBuffer.AsSpan doubled the buffer only once, which was insufficient for strings exceeding 2x the initial capacity. Use while loop to ensure the buffer grows enough. (fixes #168) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hadashiA
force-pushed
the
fix/expand-buffer-capacity
branch
from
95da31b to
41bdb6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExpandBuffer<T>.AsSpan(int length)to usewhileinstead ofifwhen growing the bufferArgumentOutOfRangeExceptionCloses #168
Test plan
Serialize_LongStringtest with a 3000-char string🤖 Generated with Claude Code