Fix infinite loop when YAML ends with colon at EOF#174
Merged
Conversation
When a YAML stream ends with a mapping value indicator (:) with no following content or newline, TryPeek returned false causing the colon to be misclassified as a plain scalar, leading to an infinite loop. Now treat EOF after colon as a valid mapping value indicator. (fixes #167) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MapValueIndentcase inUtf8YamlTokenizer.ConsumeNextToken()to handle EOF after colonTryPeek(1, out var nextCode) && YamlCodes.IsEmpty(nextCode)returned false at EOF, causing the colon to fall through toConsumePlainScalar()and trigger an infinite loop inConsumeMoreTokens()BlockEntryIndentandExplicitKeyIndentcases which already use!TryPeek(...) || YamlCodes.IsEmpty(...)Closes #167
Test plan
MappingKeyWithColonAtEoftest with 5s timeout to catch hangs🤖 Generated with Claude Code