Fix compiler warnings CS0108 and CS8604#178
Merged
Conversation
- CS0108: Emit 'new' modifier on __RegisterVYamlFormatter() when base type has [YamlObject], avoiding "hides inherited member" warning - CS8604: Add null-forgiving operator for container in CSharpSyntaxHelper Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- CS8604: Add null-forgiving on ArraySegment.Array in ByteArrayFormatter - CS8714: Use non-nullable key type for Dictionary in PrimitiveObjectFormatter - CS8620: Use nullable string value type in EnumAsStringFormatter to match compat shim Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__RegisterVYamlFormatter()in derived types now usesnewmodifier when base type has[YamlObject]CSharpSyntaxHelper.cs(copied from dotnet/runtime)Changes
VYaml.SourceGenerator/Emitter.cs— Check if base type has[YamlObject]and emitnewmodifier accordinglyVYaml.SourceGenerator/Shims/CSharpSyntaxHelper.cs—container!to suppress nullable warningTest plan
dotnet buildproduces zero CS warnings🤖 Generated with Claude Code