-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Mark our PTX kernels as kernels, to stop them from being stripped #8571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The mac failure is something about orc and unwinding exceptions through jit-compiled code on mac, which we don't need, but I don't immediately see how to turn it off. |
Let's merge this already to revive all the other tests. I need them to validate the transcendentals. |
I pushed a version without the ifdef, but we'll have to wait for the bots to verify it works with llvm 18 |
Time to learn about the buildbots. Can I temporarily disable build bots on my PR by adding the skip_buildbots tag and remove it later? Would be useful to free up build bot compute for priority PRs like this. |
How did you diagnose this? Also, two thoughts:
|
I diagnosed it by searching the LLVM source for the cantFail call that failed. LLVM's orc is the JIT engine for all platforms, and they recently made some macos changes. Unwinding is specific to exceptions. We can't actually do any unwinding through our generated code because we don't register any unwinding information to do things like free our allocations, so it doesn't matter if the JIT engine supports it. The runtime isn't allowed to throw exceptions for this reason too. |
Halide also has a handful of |
@abadams The mac failure seemed to disappear overnight. I guess this was a real mistake on LLVM's side... |
No description provided.