Skip to content

Commit 0768d48

Browse files
alexreinkingclaude
andcommitted
Stop overriding GitHubStatusPush's default generators
The explicit `generators=[BuildStartEndStatusGenerator(...)]` here dropped buildbot's own default `BuildRequestGenerator`, which posts a "pending" GitHub status as soon as a build is queued. Without it, a builder has no status at all until a worker actually starts it, so PRs could look all-green while several buildbots hadn't begun -- and merges landed before the builders ever ran. The `context=` override was also identical to the library default. Removing both restores the queued-state status and trims config that no longer needs to exist. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 849be49 commit 0768d48

1 file changed

Lines changed: 0 additions & 10 deletions

File tree

master/master.cfg

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ from buildbot.config import BuilderConfig
1717
from buildbot.locks import WorkerLock
1818
from buildbot.process.factory import BuildFactory
1919
from buildbot.process.properties import Interpolate, Properties, Property, Transform, renderer
20-
from buildbot.reporters.generators.build import BuildStartEndStatusGenerator
2120
from buildbot.reporters.github import GitHubStatusPush
22-
from buildbot.reporters.message import MessageFormatterRenderable
2321
from buildbot.schedulers.basic import AnyBranchScheduler
2422
from buildbot.schedulers.canceller import OldBuildCanceller
2523
from buildbot.schedulers.forcesched import ForceScheduler
@@ -1281,14 +1279,6 @@ c["logCompressionMethod"] = "zstd"
12811279
c["services"] = [
12821280
GitHubStatusPush(
12831281
token=GITHUB_TOKEN,
1284-
context=Interpolate("buildbot/%(prop:buildername)s"),
1285-
generators=[
1286-
BuildStartEndStatusGenerator(
1287-
builders=[b.name for b in c["builders"]],
1288-
start_formatter=MessageFormatterRenderable("Build started."),
1289-
end_formatter=MessageFormatterRenderable("Build done."),
1290-
)
1291-
],
12921282
verbose=True,
12931283
),
12941284
OldBuildCanceller(

0 commit comments

Comments
 (0)