-
Notifications
You must be signed in to change notification settings - Fork 0
Rename ModelContextProtocol and ModelContextProtocol.Hosting packages #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: halter73 <[email protected]>
…ol.Core, ModelContextProtocol.Hosting -> ModelContextProtocol Co-authored-by: halter73 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to move the files to the directories they would be in if they started with the current PackageId, and update the csproj file names to match their folder and PackageId.
@@ -4,8 +4,8 @@ | |||
<TargetFrameworks>net9.0;net8.0;netstandard2.0</TargetFrameworks> | |||
<GenerateDocumentationFile>true</GenerateDocumentationFile> | |||
<IsPackable>true</IsPackable> | |||
<PackageId>ModelContextProtocol</PackageId> | |||
<Description>.NET SDK for the Model Context Protocol (MCP)</Description> | |||
<PackageId>ModelContextProtocol.Core</PackageId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, when I said minimal changes, I did not mean to not move files around. In addition to renaming this PackageId to ModelContextProtocol.Core, we should rename this file to ModelContextProtocol.Core.csproj and put it in the src/ModelContextProtocol.Core directory. After doing that, the src/ModelContextProtocol.Hosting folder should be renamed to src/ModelContextProtocol and ModelContextProtocol.Hosting.csproj should be renamed to ModelContextProtocol.csrpoj. It's important to move directories in this order because we don't want to clobber anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed the directory reorganization in the exact order you specified:
- Moved src/ModelContextProtocol to src/ModelContextProtocol.Core and renamed ModelContextProtocol.csproj to ModelContextProtocol.Core.csproj
- Moved src/ModelContextProtocol.Hosting to src/ModelContextProtocol and renamed ModelContextProtocol.Hosting.csproj to ModelContextProtocol.csproj
- Updated solution file and all project references throughout the codebase
All files now match their PackageId folder structure. Changes in commit 671a21a.
Co-authored-by: halter73 <[email protected]>
Done! Files and directories have been moved to match their PackageId names and all project references have been updated. Commit 671a21a implements the directory reorganization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the first section of the main README.md at the root of the project ("# MCP C# SDK") to include links to the ModelContextProtocol.Core package and the ModelContextProtocol.AspNetCore NuGet packages and relative links to their respective READMEs? We should describe its purpose of each package. ModelContextProtocol being the right fit for most projects that don't need HTTP server capabilities. ModelContextProtocol.AspNetCore being the library for HTTP-based MCP servers. And ModelContextProtocol.Core being for people who only need to use the client or low-level server APIs and want the minimum number of dependencies.
…riptions Co-authored-by: halter73 <[email protected]>
Added a "Packages" section to the main README with NuGet package links, badges, relative links to documentation, and clear descriptions of each package's purpose as requested. Commit 6e10645. |
This PR implements the package renaming strategy to better reflect the package hierarchy and usage patterns:
Changes Made
Package Renaming
ModelContextProtocol
→ModelContextProtocol.Core
: The core package now clearly indicates it provides fundamental MCP functionality without hosting featuresModelContextProtocol.Hosting
→ModelContextProtocol
: The main package now includes hosting and dependency injection extensions, making it the primary entry point for most usersNamespace Updates
ModelContextProtocol.Hosting
namespace toModelContextProtocol
namespace:SingleSessionMcpServerHostedService
McpServerOptionsSetup
Documentation Changes
AddMcpServer()
and hosting featuresPackage Descriptions
Impact
This change provides a clearer package structure:
The namespace changes are internal only and don't affect public APIs. All existing functionality remains unchanged.
Fixes #6.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.