chore(hanzo-memory): drop orphaned Redis service from compose - #34
Merged
Conversation
The `memory` service never set REDIS_URL and never wired itself to the Redis container. Runtime config (src/hanzo_memory/config.py) defaults redis_url=None — caching via Redis is optional and unconfigured. The `redis:` block was a dead, profile-gated (with-cache) declaration with no consumer. Per "no redis, no kv" policy: remove the orphaned block and its volume. No consumer migration needed (nothing consumed it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the orphaned
redis:service (and itsredis_datavolume) frompkg/hanzo-memory/compose.yml.Files modified
pkg/hanzo-memory/compose.ymlWhy this is a clean drop (no consumer migration)
The
memoryservice in this compose never referenced Redis:REDIS_URLenv var.depends_on: redis.Runtime confirms Redis was always optional and unconfigured:
src/hanzo_memory/config.pydefaultsredis_url=None.redis:block was gated behind thewith-cacheprofile with noservice ever joining it.
This is an orphaned declaration — nothing consumed it, so there is no
base migration to perform. Per the "no redis / no kv" policy the dead block
is simply deleted.
Tested