Skip to content

Add debug logging to migrator. #7381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2025
Merged

Add debug logging to migrator. #7381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7a79da
Add debug logging to migrator.
michaelabuckley Nov 13, 2025
d4dd19a
fix message param order
michaelabuckley Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hapi-fhir-sql-migrate/src/main/java/ca/uhn/fhir/jpa/migrate/HapiMigrator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ private void recordTaskAsCompletedIfNotDryRun(BaseTask theNext, long theExecutio

public void addTasks(Iterable<BaseTask> theMigrationTasks) {
if (HapiSystemProperties.isUnitTestModeEnabled()) {
ourLog.info("Skipping tasks because unit test mode is enabled");
// Tests only need to initialize the schemas. No need to run all the migrations for every test.
for (BaseTask task : theMigrationTasks) {
if (task instanceof InitializeSchemaTask) {
Expand Down
7 changes: 4 additions & 3 deletions hapi-fhir-sql-migrate/src/main/java/ca/uhn/fhir/jpa/migrate/taskdef/BaseTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,9 @@ private int doExecuteSql(@Language("SQL") String theSql, Object... theArguments)
} catch (DataAccessException e) {
if (myFlags.contains(TaskFlagEnum.FAILURE_ALLOWED)) {
ourLog.info(
"Task {} did not exit successfully on doExecuteSql(), but task is allowed to fail",
getMigrationVersion());
"Task {} running sql \"{}\"did not exit successfully on doExecuteSql(), but task is allowed to fail",
getMigrationVersion(),
theSql);
ourLog.debug("Error was: {}", e.getMessage(), e);
myExecutionResult = MigrationTaskExecutionResultEnum.NOT_APPLIED_ALLOWED_FAILURE;
return 0;
Expand Down Expand Up @@ -334,7 +335,7 @@ public final int hashCode() {

@Override
public final boolean equals(Object theObject) {
if (theObject == null || getClass().equals(theObject.getClass()) == false) {
if (theObject == null || !getClass().equals(theObject.getClass())) {
return false;
}
BaseTask otherObject = (BaseTask) theObject;
Expand Down
Loading