BUG/MINOR: use int64 format for memory information#117
Closed
jmdelafe wants to merge 2 commits intohaproxytech:masterfrom
jmdelafe:patch-1
Closed
BUG/MINOR: use int64 format for memory information#117jmdelafe wants to merge 2 commits intohaproxytech:masterfrom jmdelafe:patch-1
int64 format for memory information#117jmdelafe wants to merge 2 commits intohaproxytech:masterfrom
jmdelafe:patch-1
Conversation
It defaults to `int32` when no specified and that is not enough for modern machines with way more than 2 GBs
Collaborator
|
What is the exact issue, as they are generated as int64 here: https://github.com/haproxytech/client-native/blob/master/models/info.go#L443 |
Contributor
Author
|
I found the issue when building a Data Plane API (v3) client for Go. I used https://openapi-generator.tech/ to build it. |
Contributor
Author
|
I found the issue, @mjuraga. It seems that I will update my configuration to use I will close this pull request. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It defaults to
int32when not specified, and that is not enough for modern machines with way more than 2 GB of memory.