Repository navigation
Conversation
The web engine stamps every node a nested document reads with the chain of iframe selectors that encloses it, outermost first, as upstream's toSemanticNode does (packages/web/src/observation.ts). The selector of each iframe is read in the page by PageScript.FrameSelector (upstream's frameSelectorOf). The main document carries no frame path. Selector stays unset on web nodes: upstream's web engine never sets a node's selector, only the mobile engine does, so the port matches it. The unknown field drop of redactNode has no C# counterpart; COMPATIBILITY.md records both. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
… parity gaps describeTarget records the target's structural selector (upstream's target.selector, redacted and bounded). The port now carries it as provenance on RecordedAction and RecordedTarget. Relocation never reads it, and anchors leave it out, as upstream's anchors.ts does. Regenerates the RecordedAction and RecordedTarget API pages. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…ck selector The frame selector is read after the owner and depth checks, so a frame that is not read costs no round trip and a failed selector read no longer drops the frame's owner and inset. Upstream's descriptor reader length-checks every descriptor field, selector included, so HasValidDescriptor now does too. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Repo rule: a partially ported test carries the Partial_ prefix. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1324
Summary
SemanticNode.FramePath: each node of a nested document carries the chain of iframe selectors enclosing it, outermost first, as upstream'stoSemanticNodedoes. The selector of each iframe is read in the page byPageScript.FrameSelector(upstream'sframeSelectorOf).selectoras provenance (RecordedAction.Selector,RecordedTarget.Selector). Relocation never reads it and anchors leave it out, as upstream does.HasValidDescriptorlength-checksSelector, as upstream'sreadDescriptordoes.Deliberately not changed:
Selector. Upstream'spackages/webnever sets a node'sselector; only the mobile engine does, and the port already matches that.redactNodehas no C# counterpart (a typedSemanticNodecarries no undeclared key). Recorded in COMPATIBILITY.md.Upstream parity
Upstream change: tester-army/e2e
4ce01b29(#729, selector and framePath redaction,describeTargetselector, anchors strip selector) and the #1303 test inpackages/e2e/tests/unit/agent-observation.test.ts. The other parts of #729 are outside this issue.selectorandframePath,projectTree,describeTargetselector, anchor strip, webframePathpopulation,frameSelectorOfasPageScript.FrameSelector); renamed: none; partial:Partial_records_the_durable_descriptors_of_each_action(the port's actions are flat, with its own summary wording); missing: none.PageScript.FrameSelector: a JS constant inPageScript, which holds the port's page scripts.SelectorOfAsync: reads the frame selector only for a frame being read.WebNode.FramePathandSetFramePath: the port builds WebNode DTOs beforeToNode; upstream passesframePathintotoSemanticNode.RecordedAction.SelectorandRecordedTarget.Selector: flat fields, matching the port's descriptor shape.FramePathTests: .NET-only; no upstreamitreadsframePathoff an observed web node.redactNode(no C# counterpart); webSelectornot set (upstream web does not set it either).Partial_prefix on the partial test); public surface:RecordedAction.mdandRecordedTarget.mdregenerated; no user guide documents descriptor fields.Tests
E2E.Tests(before the review fixes): 3,901 passed; oneControlsTestsfile-chooser timing flake, which passed on rerun.Huge_Virtualized_Listalso fails on untouchedorigin/main(recorded as a finding).Infinite_Scroll_Listpasses on a clean replay cache. MobileApp: 9 failures (needs a device or Appium; not run on main).dotnet format --verify-no-changes: fails for environmental reasons (CRLF checkout undercore.autocrlfagainst the LF.editorconfig) and two pre-existing WHITESPACE errors atWebEngine.cs:1533, on lines this branch does not touch.🤖 Generated with Claude Code