Test/stable db tests #194
Open
Test/stable db tests #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsson49
reviewed
Sep 18, 2019
| @MethodSource("validArgumentsProvider") | ||
| void testValidCreation(String path, long bufferLimitsInBytes) { | ||
| final Database database = Database.rocksDB(path, bufferLimitsInBytes); | ||
| assertThat(database).isNotNull(); |
There was a problem hiding this comment.
Useless isNotNull test again.
ericsson49
reviewed
Sep 18, 2019
| assertThat(closed).isFalse(); | ||
| db.close(); | ||
| assertThat(closed).isTrue(); | ||
| } |
There was a problem hiding this comment.
This test tests your implementation of Database interface. Useless again.
ericsson49
reviewed
Sep 18, 2019
| Arguments.of("/tmp", 0), | ||
| Arguments.of("/tmp", Long.MAX_VALUE), | ||
| Arguments.of("/tmp", Long.MIN_VALUE)); | ||
| } |
There was a problem hiding this comment.
This likely won't work on windows.
Additionaly, RocksDB creates files. It's a good idea to clean up, i.e. remove the directories, created by RocksDB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.