test: regression coverage for DBOPS, diagnose single-step guard, CCM filters - #698
Closed
cursor[bot] wants to merge 1 commit into
Closed
test: regression coverage for DBOPS, diagnose single-step guard, CCM filters#698cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…CM filters - database_changeset_existence: reject missing/empty ids, >100 limit, non-string/blank entries; accept changeSetIds alias and trim whitespace - harness_diagnose pipeline: suppress all_step_logs when step_id is set (single-step mode guard from #691) - cost_recommendation_count/stats: omit costCategoryDTOs when only cost_category is provided without cost_buckets Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
Collaborator
|
Closing after draft cleanup: the still-useful regression coverage is consolidated in retained #716 and the relevant focused drafts/fixes, so this branch no longer has a unique improvement worth keeping open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds targeted regression tests for recently merged production paths that lacked validation or guard coverage.
Triggered by inspection of recent merges (#679 DBOPS changeset existence, #691 diagnose single-step mode, #617 CCM recommendation filters). PR #696 (schema auto-sync) is data-only; schema contract tests are deferred until that lands.
Risky behavior now covered
database_changeset_existencebodyBuilder ([feat]: [DBOPS-2684]: DBOPS changeset existence check API addition #679) — rejects missing/emptychangeset_ids, >100 ids, non-string/blank entries; acceptschangeSetIdscamelCase alias and trims whitespace.harness_diagnosesingle-step guard (feat: unify pipeline_summarizer into failure+success analyzer with RCA #691) — whenstep_idis present,include_all_step_logsis suppressed so callers stay in single-step mode.costCategoryDTOsomitted when onlycost_categoryis provided withoutcost_buckets.Test files updated
tests/registry/dbops.test.ts— 7 new casestests/tools/diagnose/pipeline.test.ts— 1 new casetests/registry/registry.test.ts— 2 new casesWhy these reduce regression risk
?step=.Type of Change
Checklist
pnpm testpasses (targeted: 235 tests in 3 files)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses (N/A — no registry changes)