make path of server binary configurable #493
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubbortlik
reviewed
May 7, 2025
jakubbortlik
reviewed
May 7, 2025
| @@ -147,6 +147,7 @@ you call this function with no values the defaults will be used: | |||
| port = nil, -- The port of the Go server, which runs in the background, if omitted or `nil` the port will be chosen automatically | |||
| log_path = vim.fn.stdpath("cache") .. "/gitlab.nvim.log", -- Log path for the Go server | |||
| config_path = nil, -- Custom path for `.gitlab.nvim` file, please read the "Connecting to Gitlab" section | |||
| bin = nil, -- Custom path to Go server binary, if not set the internal one is used. Only change if really needed | |||
There was a problem hiding this comment.
Maybe you could give a specific example, so instead of "Only change if really needed" you could say something like:
Suggested change
| bin = nil, -- Custom path to Go server binary, if not set the internal one is used. Only change if really needed | |
| bin = nil, -- Custom path to Go server binary, if not set the internal one is used. Useful if the directory of the plugin is read-only. |
But I'm also wondering, how you compile the server? Do you have to take the extra steps of cloning the repo to a different location? Wouldn't it be more user friendly to just customize the path where the server is supposed to be built, so that the user doesn't have to take any further steps?
Co-authored-by: Jakub F. Bortlík <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the path to the Go server binary configurable. If setting argument 'bin' is not 'nil' the compilation is skipped and the value of 'bin' is used to execute the Go server from.
I needed this to make it easier to use this plugin in my nix system, as the directory of the plugin is readonly in nix system the compilation fails.
Let me know whether you want met to change something.
Btw: Thanks for the work on this great plugin.