SMM is not enabled when TPM is enabled in VMware source client

[votdev]

When TPM is enabled, SMM should be enabled as well. The OpenStack client part is doing that already, but the VMware client is missing that.

This PR makes also use of the pointer.BoolXXX() helper functions to secure de-referencing of nil pointers.

Related to: harvester/harvester#7984

[Copilot]

Pull Request Overview

This PR fixes an issue where SMM is not enabled when TPM is enabled on VMware virtual machines, while also standardizing the use of pointer helper functions for safely dereferencing nil pointers. Key changes include:

• Enabling SMM if either secure boot or TPM is enabled in the VMware client.
• Updating test assertions and error messages for consistency.
• Standardizing boolean pointer usage across VMware and OpenStack client implementations.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
pkg/source/vmware/client_test.go	Updates test assertions and docker image tag, and adds secureboot tests
pkg/source/vmware/client.go	Refines firmware, secure boot, TPM, and SMM configuration logic
pkg/source/openstack/client.go	Standardizes pointer helper usage and similar configuration updates

Comments suppressed due to low confidence (2)

pkg/source/vmware/client_test.go:208

• [nitpick] Consider using consistent capitalization in error messages (e.g., 'VM export' vs. 'VM CR generation') for clarity and uniformity.

assert.NoError(err, "expected no error during vm export")

pkg/source/vmware/client.go:394

• [nitpick] Consider refactoring the shared firmware and security features configuration (secure boot, TPM, and SMM) into a common helper to reduce duplication with the OpenStack client implementation.

// setup bios/efi, secureboot and tpm settings

[starbops]

LGTM, I have one simple question: Should we also add a unit test for the OpenStack source client?

[votdev]

LGTM, I have one simple question: Should we also add a unit test for the OpenStack source client?

@starbops Done by extracting the relevant code into a helper function which can be easily tested via unit test.

[starbops]

LGTM, thank you.

[w13915984028]

LGTM, thanks.

[w13915984028]

LGTM, thanks.