[ENHANCEMENT] Improve auto-detection of the disk bus type of the VMware importer #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new default value is |
votdev
force-pushed
the
issue_7987_bustype
branch
from
230e536 to
d7d305b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
votdev
changed the title
votdev
force-pushed
the
issue_7987_bustype
branch
2 times, most recently
from
48a953b to
ddc1579
Compare
votdev
force-pushed
the
issue_7987_bustype
branch
2 times, most recently
from
2cf5f65 to
24c96d4
Compare
votdev
force-pushed
the
issue_7987_bustype
branch
from
24c96d4 to
8fc9114
Compare
votdev
changed the title
|
Thought about adding a |
votdev
force-pushed
the
issue_7987_bustype
branch
2 times, most recently
from
95770f8 to
c65ca39
Compare
|
This pull request is now in conflict. Could you fix it @votdev? 🙏 |
Related to: harvester/harvester#7987 Signed-off-by: Volker Theile <[email protected]>
Signed-off-by: Volker Theile <[email protected]>
This allows the user to customize the disk bus type in case the auto-detection fails. Note, the OpenStack source client does not support auto-detection, thus it will always make use of the `DefaultDiskBusType` field if specified. The `DefaultDiskBusType` defaults to `virtio`. Signed-off-by: Volker Theile <[email protected]>
votdev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IDE disk bus is not supported anymore in the kubevirt version we are using: kubevirt.io/api-reference/v1.1.0/definitions.html#_v1_disktarget
This PR is mapping it to SATA because VirtIO requires the kernel drivers to be installed in the VM which can not be guaranteed.
This is the mapping of the VMware source client:
The new
DefaultDiskBusTypefield inVirtualMachineImportSpecallows the user to customize the disk bus type in case the auto-detection fails. Note, the OpenStack source client does not support auto-detection, thus it will always make use of theDefaultDiskBusTypefield if specified. TheDefaultDiskBusTypedefaults tovirtio.Related Issue:
harvester/harvester#7987
Test plan:
Use added unit tests.