Skip to content

feat: adding front-end support for registered node update transactions#2892

Merged
ericleponner merged 2 commits into
mainfrom
2888_update_registered_node_frontend_support
May 27, 2026
Merged

feat: adding front-end support for registered node update transactions#2892
ericleponner merged 2 commits into
mainfrom
2888_update_registered_node_frontend_support

Conversation

@ericleponner
Copy link
Copy Markdown
Contributor

@ericleponner ericleponner commented May 26, 2026

Description:

Changes below:

  • add Registered Node Update transaction to Create Transaction modal
  • enable Draft Creation form to create a RegisteredNodeUpdate transaction
  • enable TransactionDetails page to display specific info to RegisteredNodeUpdate transaction

In addition they fix a latent issue in NodeUpdate.vue.

New Registered Node Delete command in Transaction Selection modal:
image

Form for creating Registered Node Update transaction:
image

Transaction Details for registered node update transaction:
image

Related issue(s):

Fixes #2888
Fixes #2827

Notes for reviewer:

M   front-end/src/renderer/components/TransactionSelectionModal.vue
    # Adds 'Registered Node Update' command to Transaction Type selection modal.

A   front-end/src/renderer/components/Transaction/Create/RegisteredNodeUpdate/RegisteredNodeUpdate.vue
A   front-end/src/renderer/components/Transaction/Create/RegisteredNodeUpdate/RegisteredNodeUpdateFormData.vue
A   front-end/src/renderer/components/Transaction/Create/RegisteredNodeUpdate/index.ts
M   front-end/src/renderer/components/Transaction/Create/txTypeComponentMapping.ts
M   front-end/src/renderer/utils/sdk/createTransactions.ts
M   front-end/src/renderer/utils/sdk/getData.ts
M   front-end/src/renderer/utils/sdk/transactions.ts
    # Enables draft editor to create and update RegisteredNodeUpdateTransaction.

M   front-end/src/renderer/components/Transaction/Details/RegisteredNodeDetails.vue
M   front-end/src/renderer/components/Transaction/Details/txTypeComponentMapping.ts
M   front-end/src/renderer/components/ExternalSigning/TransactionBrowser/TransactionBrowserPage.vue
    # Enables transaction details and TransactionBrowserPage to display RegisteredNodeUpdateTransaction.

A   front-end/src/renderer/utils/transactionSignatureModels/registered-node-update-transaction.model.ts
M   front-end/src/renderer/utils/transactionSignatureModels/index.ts
M   front-end/src/renderer/utils/transactionSignatureModels/transaction-factory.ts
    # New transaction model for RegisterdNodeUpdateTransaction.

M   front-end/src/renderer/components/Transaction/Create/NodeUpdate/NodeUpdate.vue
    # handleUpdateData() now avoids to send NaN to mirror node 

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ericleponner ericleponner self-assigned this May 26, 2026
@swirlds-automation
Copy link
Copy Markdown

swirlds-automation commented May 26, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.98%. Comparing base (f438169) to head (7ac300e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2892   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         184      184           
  Lines        5689     5689           
  Branches      983      998   +15     
=======================================
  Hits         5688     5688           
  Misses          1        1           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ericleponner ericleponner marked this pull request as ready for review May 26, 2026 16:49
@ericleponner ericleponner requested a review from a team as a code owner May 26, 2026 16:49
@ericleponner ericleponner requested review from jbair06 and svienot May 26, 2026 16:49
@ericleponner ericleponner marked this pull request as draft May 26, 2026 16:50
@ericleponner ericleponner force-pushed the 2888_update_registered_node_frontend_support branch from 7d7b5c7 to fc6c95d Compare May 27, 2026 07:31
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner ericleponner force-pushed the 2888_update_registered_node_frontend_support branch from fc6c95d to a51c924 Compare May 27, 2026 08:43
@ericleponner ericleponner marked this pull request as ready for review May 27, 2026 08:45
… mirror node.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Copy link
Copy Markdown
Contributor

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericleponner ericleponner merged commit 73d563b into main May 27, 2026
26 checks passed
@ericleponner ericleponner deleted the 2888_update_registered_node_frontend_support branch May 27, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding support for RegisteredNodeUpdate transaction to front-end HIP-1137 Update Registered Node

3 participants