SPIKE: convert integration tests to gts/gjs #3326
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| import { click, render, settled, find } from '@ember/test-helpers'; | ||
| import Accordion from '@hashicorp/design-system-components/components/hds/accordion/index'; | ||
| import Item from '@hashicorp/design-system-components/components/hds/accordion/item/index'; | ||
| import { tracked } from 'tracked-built-ins'; |
There was a problem hiding this comment.
ideally we would only use specific packages like TrackedArray, TrackedObject etc. from this package otherwise use @glimmer/tracking
as very soon we will migrate from tracked-built-ins to @ember/reactivity/collections https://rfcs.emberjs.com/id/1068-tracked-collections
There was a problem hiding this comment.
Ah ok! I can update.
| import { click, render } from '@ember/test-helpers'; | ||
| import { hbs } from 'ember-cli-htmlbars'; | ||
| import { click, render, settled, find } from '@ember/test-helpers'; | ||
| import Accordion from '@hashicorp/design-system-components/components/hds/accordion/index'; |
There was a problem hiding this comment.
I do recognize this is done by codemod also probably up to HDS but it migth make sene to import this how it's being used on consumer side like
| import Accordion from '@hashicorp/design-system-components/components/hds/accordion/index'; | |
| import { HdsAccordion, HdsItem } from '@hashicorp/design-system-components/components'; |
with that being said either way works fine
There was a problem hiding this comment.
Yeah I agree, I'm planning to do a commit at the end where I fix all the import paths.
3 participants
📌 Summary
🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.