Use configurable container runtime in e2e tests instead of hardcoded Docker commands - #358
Open
sammcgeown wants to merge 4 commits into
Open
Use configurable container runtime in e2e tests instead of hardcoded Docker commands#358sammcgeown wants to merge 4 commits into
sammcgeown wants to merge 4 commits into
Conversation
…KER env var with a docker fallback Replace all hardcoded docker strings in both test files Export DOCKER= from the Makefile's test-e2e target so the env var reaches the Go test process
…KER env var with a docker fallback Replace all hardcoded docker strings in both test files Export DOCKER=$(DOCKER) from the Makefile's test-e2e target so the env var reaches the Go test process
sammcgeown
force-pushed
the
fix-hardcoded-docker
branch
from
May 8, 2026 12:52
b82cdae to
367ccf1
Compare
sammcgeown
force-pushed
the
fix-hardcoded-docker
branch
from
May 8, 2026 12:53
367ccf1 to
c6c00d2
Compare
Member
|
this is cool, should help us support podman :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e2e test flow hardcoded
dockerin test helper commands, even though the Makefile already supports a configurable container runtime viaDOCKERvariable.That caused
make test-e2eto fail in environments using Podman or another Docker-compatible runtime, because the Go tests ignored the configured runtime and invokeddockerdirectly.Changes Made
Why This Fix
Scope
Test infrastructure only.
No changes to server runtime behaviour or production container images.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.