Skip to content

Conversation

@alexbacchin
Copy link
Contributor

@alexbacchin alexbacchin commented Nov 6, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
No

Description

This pull request introduces a new data source for AWS ACM PCA Certificate Authorities to the provider, allowing users to query and filter certificate authorities, including those shared via AWS Resource Access Manager (RAM). The implementation includes the data source code, integration into the service package, comprehensive acceptance tests, and documentation for usage and arguments.

New Data Source Implementation

aws_acmpca_certificate_authorities data source, enabling retrieval of ACM PCA Certificate Authority ARNs with optional filtering by resource owner (SELF or OTHER_ACCOUNTS).
The API does not support additional filtering.

Relations

Closes #44255

References

Output from Acceptance Testing

% make testacc TESTS=TestAccACMPCACertificateAuthoritiesDataSource PKG=acmpca
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws_acmpca_certificate_authorities 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/acmpca/... -v -count 1 -parallel 20 -run='TestAccACMPCACertificateAuthoritiesDataSource'  -timeout 360m -vet=off
2025/11/06 19:24:19 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/06 19:24:19 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccACMPCACertificateAuthoritiesDataSource_basic
=== PAUSE TestAccACMPCACertificateAuthoritiesDataSource_basic
=== RUN   TestAccACMPCACertificateAuthoritiesDataSource_otherAccounts
=== PAUSE TestAccACMPCACertificateAuthoritiesDataSource_otherAccounts
=== CONT  TestAccACMPCACertificateAuthoritiesDataSource_basic
=== CONT  TestAccACMPCACertificateAuthoritiesDataSource_otherAccounts
--- PASS: TestAccACMPCACertificateAuthoritiesDataSource_basic (19.30s)
--- PASS: TestAccACMPCACertificateAuthoritiesDataSource_otherAccounts (37.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/acmpca     41.754s

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/acmpca Issues and PRs that pertain to the acmpca service. generators Relates to code generators. size/L Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels Nov 6, 2025
@alexbacchin alexbacchin changed the title F aws acmpca certificate authorities d/aws_acmpca_certificate_authorities: new data source Nov 6, 2025
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Nov 6, 2025
@alexbacchin alexbacchin marked this pull request as ready for review November 6, 2025 09:26
@alexbacchin alexbacchin requested a review from a team as a code owner November 6, 2025 09:26
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. new-data-source Introduces a new data source. service/acmpca Issues and PRs that pertain to the acmpca service. size/L Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New data source: aws_acmpca_certificate_authorities

2 participants