Skip to content

Conversation

@8me
Copy link

@8me 8me commented Nov 9, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Description

When one of the attributes is changed which require a start/stop, the EC2 is powered on even if it was in powerstate on before. This one is a sketch to introduce a flag which allows to skip the start if it was off.
With the flag, the change should not cause a breaking change to the behavior of the provider.

Testing

Did not add some tests for now, as I would need some help to properly implement this.

Cannot run acceptance test as EC2 type changes are not included in free tier AWS.

@8me 8me requested a review from a team as a code owner November 9, 2025 17:06
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. labels Nov 9, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants