Skip to content

[bugfix] removed valkey engine from elasticache cluster to align with aws sdk #45017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[bugfix] removed valkey engine from elasticache cluster to align with aws sdk #45017

wants to merge 6 commits into from

Conversation

@sukumaar
Copy link

@sukumaar sukumaar commented Nov 10, 2025 •
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Removed valkey engine option while creating elasticache cluster resource.

This aligns with aws sdk CreateCacheClusterInput . CreateCacheClusterInput has Engine field , as per the comment in source code 'Valid values for this parameter are: memcached | redis ' . CreateCacheCluster has CreateCacheClusterInput as one of the parameter.

This aws docs for API_CreateCacheCluster mention supported engine, which are memcached | redis only. There is no mention of valkey.

Relations

Closes #41181

References

https://docs.aws.amazon.com/AmazonElastiCache/latest/APIReference/API_CreateCacheCluster.html
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/elasticache#CreateCacheClusterInput
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/elasticache#Client.CreateCacheCluster
#39972 (comment)
#39905

Output from Acceptance Testing

% make testacc TESTS=TestAccElastiCacheCluster PKG=elasticache ACCTEST_PARALLELISM=10
make: go1.24.10 not found
make: installing go1.24.10...
make: if you get an error, see https://go.dev/doc/manage-install to locally install various Go versions
go: downloading golang.org/dl v0.0.0-20251105190606-0264471fc46d
Downloaded   0.0% (   16384 / 74943743 bytes) ...
Downloaded  66.9% (50101904 / 74943743 bytes) ...
Downloaded 100.0% (74943743 / 74943743 bytes)
Unpacking /home/ec2-user/sdk/go1.24.10/go1.24.10.linux-arm64.tar.gz ...
Success. You may now run 'go1.24.10'
make: go1.24.10 ready
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
xargs: gofmt: No such file or directory
make: Running acceptance tests on branch: �[1m🌿 f-elasticache-cluster-valkey-remove 🌿�[0m...
TF_ACC=1 go1.24.10 test ./internal/service/elasticache/... -v -count 1 -parallel 10 -run='TestAccElastiCacheCluster'  -timeout 3880m -vet=off
go: downloading github.com/YakDriver/smarterr v0.7.0
go: downloading github.com/aws/aws-sdk-go-v2 v1.39.6
go: downloading github.com/aws/smithy-go v1.23.2
go: downloading github.com/aws/aws-sdk-go-v2/service/elasticache v1.51.1
go: downloading github.com/hashicorp/aws-sdk-go-base/v2 v2.0.0-beta.68
go: downloading github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.18.13
go: downloading github.com/aws/aws-sdk-go-v2/service/accessanalyzer v1.45.0
go: downloading github.com/aws/aws-sdk-go-v2/service/account v1.29.2
go: downloading github.com/aws/aws-sdk-go-v2/service/acm v1.37.11
go: downloading github.com/aws/aws-sdk-go-v2/service/acmpca v1.45.3
go: downloading github.com/aws/aws-sdk-go-v2/service/amp v1.41.1
go: downloading github.com/aws/aws-sdk-go-v2/service/amplify v1.38.3
go: downloading github.com/aws/aws-sdk-go-v2/service/apigateway v1.36.1
go: downloading github.com/aws/aws-sdk-go-v2/service/apigatewayv2 v1.32.11
go: downloading github.com/aws/aws-sdk-go-v2/service/appconfig v1.43.1
go: downloading github.com/aws/aws-sdk-go-v2/service/appfabric v1.16.10
go: downloading github.com/aws/aws-sdk-go-v2/service/appflow v1.51.1
go: downloading github.com/aws/aws-sdk-go-v2/service/appintegrations v1.36.10
go: downloading github.com/aws/aws-sdk-go-v2/service/applicationinsights v1.34.9
go: downloading github.com/aws/aws-sdk-go-v2/service/applicationautoscaling v1.41.2
go: downloading github.com/aws/aws-sdk-go-v2/service/appmesh v1.35.1
go: downloading github.com/aws/aws-sdk-go-v2/service/applicationsignals v1.17.2
go: downloading github.com/aws/aws-sdk-go-v2/service/appstream v1.50.4
go: downloading github.com/aws/aws-sdk-go-v2/service/apprunner v1.39.3
go: downloading github.com/aws/aws-sdk-go-v2/service/appsync v1.52.1
go: downloading github.com/aws/aws-sdk-go-v2/service/arcregionswitch v1.2.12
go: downloading github.com/aws/aws-sdk-go-v2/service/athena v1.55.10
go: downloading github.com/aws/aws-sdk-go-v2/service/auditmanager v1.46.1
go: downloading github.com/aws/aws-sdk-go-v2/service/autoscaling v1.60.3
go: downloading github.com/aws/aws-sdk-go-v2/service/autoscalingplans v1.30.3
go: downloading github.com/aws/aws-sdk-go-v2/service/backup v1.50.0
go: downloading github.com/aws/aws-sdk-go-v2/service/batch v1.58.4
go: downloading github.com/aws/aws-sdk-go-v2/service/bcmdataexports v1.12.3
go: downloading github.com/aws/aws-sdk-go-v2/service/bedrock v1.48.4
go: downloading github.com/aws/aws-sdk-go-v2/service/bedrockagent v1.51.1
go: downloading github.com/aws/aws-sdk-go-v2/service/bedrockagentcorecontrol v1.13.1
go: downloading github.com/aws/aws-sdk-go-v2/service/billing v1.8.4
go: downloading github.com/aws/aws-sdk-go-v2/service/budgets v1.41.1
go: downloading github.com/aws/aws-sdk-go-v2/service/chatbot v1.14.10
go: downloading github.com/aws/aws-sdk-go-v2/service/chime v1.41.1
go: downloading github.com/aws/aws-sdk-go-v2/service/chimesdkmediapipelines v1.26.10
go: downloading github.com/aws/aws-sdk-go-v2/service/chimesdkvoice v1.28.2
go: downloading github.com/aws/aws-sdk-go-v2/service/cleanrooms v1.37.1
go: downloading github.com/aws/aws-sdk-go-v2/service/cloud9 v1.33.9
go: downloading github.com/aws/aws-sdk-go-v2/service/cloudcontrol v1.29.1
go: downloading github.com/aws/aws-sdk-go-v2/service/cloudformation v1.68.3
go: downloading github.com/aws/aws-sdk-go-v2/service/cloudfront v1.56.0
go: downloading github.com/aws/aws-sdk-go-v2/service/cloudfrontkeyvaluestore v1.12.12
go: downloading github.com/aws/aws-sdk-go-v2/service/cloudhsmv2 v1.34.9
go: downloading github.com/aws/aws-sdk-go-v2/service/cloudsearch v1.32.1
go: downloading github.com/aws/aws-sdk-go-v2/service/cloudwatch v1.52.1
go: downloading github.com/aws/aws-sdk-go-v2/service/cloudtrail v1.53.11
go: downloading github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.58.7
go: downloading github.com/aws/aws-sdk-go-v2/service/codecatalyst v1.21.1
go: downloading github.com/aws/aws-sdk-go-v2/service/codeartifact v1.38.10
go: downloading github.com/aws/aws-sdk-go-v2/service/codebuild v1.68.2
go: downloading github.com/aws/aws-sdk-go-v2/service/codecommit v1.33.1
go: downloading github.com/aws/aws-sdk-go-v2/service/codeconnections v1.10.9
go: downloading github.com/aws/aws-sdk-go-v2/service/codedeploy v1.35.1
go: downloading github.com/aws/aws-sdk-go-v2/service/codeguruprofiler v1.29.9
go: downloading github.com/aws/aws-sdk-go-v2/service/codegurureviewer v1.34.9
go: downloading github.com/aws/aws-sdk-go-v2/service/codepipeline v1.46.10
go: downloading github.com/aws/aws-sdk-go-v2/service/codestarconnections v1.35.2
go: downloading github.com/aws/aws-sdk-go-v2/service/codestarnotifications v1.31.10
go: downloading github.com/aws/aws-sdk-go-v2/service/cognitoidentity v1.33.10
go: downloading github.com/aws/aws-sdk-go-v2/service/cognitoidentityprovider v1.57.11
go: downloading github.com/aws/aws-sdk-go-v2/service/comprehend v1.40.10
go: downloading github.com/aws/aws-sdk-go-v2/service/computeoptimizer v1.48.1
go: downloading github.com/aws/aws-sdk-go-v2/service/configservice v1.59.2
go: downloading github.com/aws/aws-sdk-go-v2/service/connect v1.144.0
go: downloading github.com/aws/aws-sdk-go-v2/service/connectcases v1.34.1
go: downloading github.com/aws/aws-sdk-go-v2/service/controltower v1.26.10
go: downloading github.com/aws/aws-sdk-go-v2/service/costandusagereportservice v1.34.2
go: downloading github.com/aws/aws-sdk-go-v2/service/costexplorer v1.59.2
go: downloading github.com/aws/aws-sdk-go-v2/service/costoptimizationhub v1.20.10
go: downloading github.com/aws/aws-sdk-go-v2/service/customerprofiles v1.54.3
go: downloading github.com/aws/aws-sdk-go-v2/service/databasemigrationservice v1.58.2
go: downloading github.com/aws/aws-sdk-go-v2/service/databrew v1.39.3
go: downloading github.com/aws/aws-sdk-go-v2/service/dataexchange v1.40.3
go: downloading github.com/aws/aws-sdk-go-v2/service/datapipeline v1.30.9
go: downloading github.com/aws/aws-sdk-go-v2/service/datasync v1.55.4
go: downloading github.com/aws/aws-sdk-go-v2/service/datazone v1.45.0
go: downloading github.com/aws/aws-sdk-go-v2/service/dax v1.29.5
go: downloading github.com/aws/aws-sdk-go-v2/service/detective v1.38.2
go: downloading github.com/aws/aws-sdk-go-v2/service/devicefarm v1.36.3
go: downloading github.com/aws/aws-sdk-go-v2/service/devopsguru v1.40.1
go: downloading github.com/aws/aws-sdk-go-v2/service/directconnect v1.38.3
go: downloading github.com/aws/aws-sdk-go-v2/service/directoryservice v1.38.4
go: downloading github.com/aws/aws-sdk-go-v2/service/dlm v1.35.4
go: downloading github.com/aws/aws-sdk-go-v2/service/docdb v1.48.1
go: downloading github.com/aws/aws-sdk-go-v2/service/docdbelastic v1.20.2
go: downloading github.com/aws/aws-sdk-go-v2/service/drs v1.36.2
go: downloading github.com/aws/aws-sdk-go-v2/service/dsql v1.10.2
go: downloading github.com/aws/aws-sdk-go-v2/service/dynamodb v1.52.4
go: downloading github.com/aws/aws-sdk-go-v2/service/ec2 v1.263.0
go: downloading github.com/aws/aws-sdk-go-v2/service/ecr v1.51.2
go: downloading github.com/aws/aws-sdk-go-v2/service/ecrpublic v1.38.2
go: downloading github.com/aws/aws-sdk-go-v2/service/efs v1.41.2
go: downloading github.com/aws/aws-sdk-go-v2/service/eks v1.74.7
go: downloading github.com/aws/aws-sdk-go-v2/service/ecs v1.67.2
go: downloading github.com/aws/aws-sdk-go-v2/service/elasticbeanstalk v1.33.11
go: downloading github.com/aws/aws-sdk-go-v2/service/elasticloadbalancing v1.33.11
go: downloading github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2 v1.51.5
go: downloading github.com/aws/aws-sdk-go-v2/service/elasticsearchservice v1.37.11
go: downloading github.com/aws/aws-sdk-go-v2/service/elastictranscoder v1.32.10
go: downloading github.com/aws/aws-sdk-go-v2/service/emr v1.55.4
go: downloading github.com/aws/aws-sdk-go-v2/service/emrcontainers v1.40.6
go: downloading github.com/aws/aws-sdk-go-v2/service/emrserverless v1.37.1
go: downloading github.com/aws/aws-sdk-go-v2/service/eventbridge v1.45.10
go: downloading github.com/aws/aws-sdk-go-v2/service/evidently v1.28.9
go: downloading github.com/aws/aws-sdk-go-v2/service/evs v1.5.6
go: downloading github.com/aws/aws-sdk-go-v2/service/finspace v1.33.10
go: downloading github.com/aws/aws-sdk-go-v2/service/firehose v1.42.1
go: downloading github.com/aws/aws-sdk-go-v2/service/fis v1.37.9
go: downloading github.com/aws/aws-sdk-go-v2/service/fms v1.44.10
go: downloading github.com/aws/aws-sdk-go-v2/service/fsx v1.63.0
go: downloading github.com/aws/aws-sdk-go-v2/service/gamelift v1.48.0
go: downloading github.com/aws/aws-sdk-go-v2/service/globalaccelerator v1.35.3
go: downloading github.com/aws/aws-sdk-go-v2/service/glacier v1.31.10
go: downloading github.com/aws/aws-sdk-go-v2/service/glue v1.132.1
go: downloading github.com/aws/aws-sdk-go-v2/service/grafana v1.32.3
go: downloading github.com/aws/aws-sdk-go-v2/service/greengrass v1.32.10
go: downloading github.com/aws/aws-sdk-go-v2/service/groundstation v1.39.0
go: downloading github.com/aws/aws-sdk-go-v2/service/guardduty v1.65.4
go: downloading github.com/aws/aws-sdk-go-v2/service/healthlake v1.36.2
go: downloading github.com/aws/aws-sdk-go-v2/service/iam v1.49.2
go: downloading github.com/aws/aws-sdk-go-v2/service/identitystore v1.34.0
go: downloading github.com/aws/aws-sdk-go-v2/service/imagebuilder v1.48.4
go: downloading github.com/aws/aws-sdk-go-v2/service/inspector v1.30.9
go: downloading github.com/aws/aws-sdk-go-v2/service/inspector2 v1.44.10
go: downloading github.com/aws/aws-sdk-go-v2/service/internetmonitor v1.26.2
go: downloading github.com/aws/aws-sdk-go-v2/service/invoicing v1.6.12
go: downloading github.com/aws/aws-sdk-go-v2/service/iot v1.69.9
go: downloading github.com/aws/aws-sdk-go-v2/service/ivs v1.48.3
go: downloading github.com/aws/aws-sdk-go-v2/service/ivschat v1.21.9
go: downloading github.com/aws/aws-sdk-go-v2/service/kafka v1.44.3
go: downloading github.com/aws/aws-sdk-go-v2/service/kendra v1.60.10
go: downloading github.com/aws/aws-sdk-go-v2/service/keyspaces v1.24.3
go: downloading github.com/aws/aws-sdk-go-v2/service/kafkaconnect v1.27.10
go: downloading github.com/aws/aws-sdk-go-v2/service/kinesis v1.42.1
go: downloading github.com/aws/aws-sdk-go-v2/service/kinesisanalytics v1.30.10
go: downloading github.com/aws/aws-sdk-go-v2/service/kinesisanalyticsv2 v1.36.11
go: downloading github.com/aws/aws-sdk-go-v2/service/kinesisvideo v1.32.9
go: downloading github.com/aws/aws-sdk-go-v2/service/kms v1.47.1
go: downloading github.com/aws/aws-sdk-go-v2/service/lakeformation v1.45.9
go: downloading github.com/aws/aws-sdk-go-v2/service/lambda v1.81.1
go: downloading github.com/aws/aws-sdk-go-v2/service/launchwizard v1.13.10
go: downloading github.com/aws/aws-sdk-go-v2/service/lexmodelbuildingservice v1.34.3
go: downloading github.com/aws/aws-sdk-go-v2/service/lexmodelsv2 v1.56.10
go: downloading github.com/aws/aws-sdk-go-v2/service/licensemanager v1.36.10
go: downloading github.com/aws/aws-sdk-go-v2/service/lightsail v1.50.4
go: downloading github.com/aws/aws-sdk-go-v2/service/location v1.50.2
go: downloading github.com/aws/aws-sdk-go-v2/service/lookoutmetrics v1.37.2
go: downloading github.com/aws/aws-sdk-go-v2/service/m2 v1.26.3
go: downloading github.com/aws/aws-sdk-go-v2/service/macie2 v1.50.2
go: downloading github.com/aws/aws-sdk-go-v2/service/mediaconnect v1.45.4
go: downloading github.com/aws/aws-sdk-go-v2/service/mediaconvert v1.84.1
go: downloading github.com/aws/aws-sdk-go-v2/service/medialive v1.85.3
go: downloading github.com/aws/aws-sdk-go-v2/service/mediapackage v1.39.10
go: downloading github.com/aws/aws-sdk-go-v2/service/mediapackagev2 v1.32.3
go: downloading github.com/aws/aws-sdk-go-v2/service/mediapackagevod v1.39.10
go: downloading github.com/aws/aws-sdk-go-v2/service/mediastore v1.29.10
go: downloading github.com/aws/aws-sdk-go-v2/service/memorydb v1.33.3
go: downloading github.com/aws/aws-sdk-go-v2/service/mgn v1.38.2
go: downloading github.com/aws/aws-sdk-go-v2/service/mq v1.34.8
go: downloading github.com/aws/aws-sdk-go-v2/service/mwaa v1.39.10
go: downloading github.com/aws/aws-sdk-go-v2/service/neptune v1.43.1
go: downloading github.com/aws/aws-sdk-go-v2/service/neptunegraph v1.21.9
go: downloading github.com/aws/aws-sdk-go-v2/service/networkfirewall v1.57.5
go: downloading github.com/aws/aws-sdk-go-v2/service/networkflowmonitor v1.10.3
go: downloading github.com/aws/aws-sdk-go-v2/service/networkmanager v1.40.3
go: downloading github.com/aws/aws-sdk-go-v2/service/networkmonitor v1.13.2
go: downloading github.com/aws/aws-sdk-go-v2/service/notifications v1.7.8
go: downloading github.com/aws/aws-sdk-go-v2/service/notificationscontacts v1.5.12
go: downloading github.com/aws/aws-sdk-go-v2/service/oam v1.23.3
go: downloading github.com/aws/aws-sdk-go-v2/service/observabilityadmin v1.8.4
go: downloading github.com/aws/aws-sdk-go-v2/service/odb v1.5.4
go: downloading github.com/aws/aws-sdk-go-v2/service/opensearch v1.52.10
go: downloading github.com/aws/aws-sdk-go-v2/service/opensearchserverless v1.27.2
go: downloading github.com/aws/aws-sdk-go-v2/service/organizations v1.46.2
go: downloading github.com/aws/aws-sdk-go-v2/service/osis v1.21.3
go: downloading github.com/aws/aws-sdk-go-v2/service/outposts v1.57.4
go: downloading github.com/aws/aws-sdk-go-v2/service/paymentcryptography v1.26.1
go: downloading github.com/aws/aws-sdk-go-v2/service/pcaconnectorad v1.15.10
go: downloading github.com/aws/aws-sdk-go-v2/service/pcs v1.14.4
go: downloading github.com/aws/aws-sdk-go-v2/service/pinpoint v1.39.10
go: downloading github.com/aws/aws-sdk-go-v2/service/pinpointsmsvoicev2 v1.26.0
go: downloading github.com/aws/aws-sdk-go-v2/service/pipes v1.23.9
go: downloading github.com/aws/aws-sdk-go-v2/service/polly v1.54.3
go: downloading github.com/aws/aws-sdk-go-v2/service/pricing v1.40.3
go: downloading github.com/aws/aws-sdk-go-v2/service/qldb v1.32.2
go: downloading github.com/aws/aws-sdk-go-v2/service/qbusiness v1.33.10
go: downloading github.com/aws/aws-sdk-go-v2/service/quicksight v1.96.0
go: downloading github.com/aws/aws-sdk-go-v2/service/ram v1.34.11
go: downloading github.com/aws/aws-sdk-go-v2/service/rbin v1.26.11
go: downloading github.com/aws/aws-sdk-go-v2/service/rds v1.108.7
go: downloading github.com/aws/aws-sdk-go-v2/service/redshift v1.59.5
go: downloading github.com/aws/aws-sdk-go-v2/service/redshiftdata v1.37.10
go: downloading github.com/aws/aws-sdk-go-v2/service/redshiftserverless v1.31.13
go: downloading github.com/aws/aws-sdk-go-v2/service/rekognition v1.51.9
go: downloading github.com/aws/aws-sdk-go-v2/service/resiliencehub v1.35.2
go: downloading github.com/aws/aws-sdk-go-v2/service/resourceexplorer2 v1.22.4
go: downloading github.com/aws/aws-sdk-go-v2/service/resourcegroups v1.33.12
go: downloading github.com/aws/aws-sdk-go-v2/service/resourcegroupstaggingapi v1.30.11
go: downloading github.com/aws/aws-sdk-go-v2/service/rolesanywhere v1.21.10
go: downloading github.com/aws/aws-sdk-go-v2/service/route53 v1.59.3
go: downloading github.com/aws/aws-sdk-go-v2/service/route53domains v1.34.8
go: downloading github.com/aws/aws-sdk-go-v2/service/route53profiles v1.9.10
go: downloading github.com/aws/aws-sdk-go-v2/service/route53recoverycontrolconfig v1.32.3
go: downloading github.com/aws/aws-sdk-go-v2/service/route53recoveryreadiness v1.26.10
go: downloading github.com/aws/aws-sdk-go-v2/service/route53resolver v1.40.10
go: downloading github.com/aws/aws-sdk-go-v2/service/rum v1.29.2
go: downloading github.com/aws/aws-sdk-go-v2/service/s3 v1.90.0
go: downloading github.com/aws/aws-sdk-go-v2/service/s3control v1.66.7
go: downloading github.com/aws/aws-sdk-go-v2/service/s3outposts v1.34.1
go: downloading github.com/aws/aws-sdk-go-v2/service/s3tables v1.11.0
go: downloading github.com/aws/aws-sdk-go-v2/service/s3vectors v1.5.0
go: downloading github.com/aws/aws-sdk-go-v2/service/sagemaker v1.221.0
go: downloading github.com/aws/aws-sdk-go-v2/service/scheduler v1.17.10
go: downloading github.com/aws/aws-sdk-go-v2/service/schemas v1.34.1
go: downloading github.com/aws/aws-sdk-go-v2/service/secretsmanager v1.39.11
go: downloading github.com/aws/aws-sdk-go-v2/service/securityhub v1.65.2
go: downloading github.com/aws/aws-sdk-go-v2/service/securitylake v1.25.2
go: downloading github.com/aws/aws-sdk-go-v2/service/serverlessapplicationrepository v1.30.1
go: downloading github.com/aws/aws-sdk-go-v2/service/servicecatalog v1.39.1
go: downloading github.com/aws/aws-sdk-go-v2/service/servicecatalogappregistry v1.35.10
go: downloading github.com/aws/aws-sdk-go-v2/service/servicediscovery v1.39.14
go: downloading github.com/aws/aws-sdk-go-v2/service/servicequotas v1.33.5
go: downloading github.com/aws/aws-sdk-go-v2/service/ses v1.34.9
go: downloading github.com/aws/aws-sdk-go-v2/service/sesv2 v1.54.2
go: downloading github.com/aws/aws-sdk-go-v2/service/sfn v1.39.11
go: downloading github.com/aws/aws-sdk-go-v2/service/shield v1.34.10
go: downloading github.com/aws/aws-sdk-go-v2/service/signer v1.31.10
go: downloading github.com/aws/aws-sdk-go-v2/service/sns v1.39.3
go: downloading github.com/aws/aws-sdk-go-v2/service/sqs v1.42.13
go: downloading github.com/aws/aws-sdk-go-v2/service/ssm v1.67.0
go: downloading github.com/aws/aws-sdk-go-v2/service/ssmcontacts v1.31.3
go: downloading github.com/aws/aws-sdk-go-v2/service/ssmincidents v1.39.9
go: downloading github.com/aws/aws-sdk-go-v2/service/ssmquicksetup v1.8.10
go: downloading github.com/aws/aws-sdk-go-v2/service/ssmsap v1.25.9
go: downloading github.com/aws/aws-sdk-go-v2/service/ssoadmin v1.36.6
go: downloading github.com/aws/aws-sdk-go-v2/service/sso v1.30.1
go: downloading github.com/aws/aws-sdk-go-v2/service/storagegateway v1.43.2
go: downloading github.com/aws/aws-sdk-go-v2/service/swf v1.33.4
go: downloading github.com/aws/aws-sdk-go-v2/service/synthetics v1.42.2
go: downloading github.com/aws/aws-sdk-go-v2/service/sts v1.39.1
go: downloading github.com/aws/aws-sdk-go-v2/service/taxsettings v1.16.10
go: downloading github.com/aws/aws-sdk-go-v2/service/timestreaminfluxdb v1.17.4
go: downloading github.com/aws/aws-sdk-go-v2/service/timestreamquery v1.36.3
go: downloading github.com/aws/aws-sdk-go-v2/service/timestreamwrite v1.35.9
go: downloading github.com/aws/aws-sdk-go-v2/service/transcribe v1.53.4
go: downloading github.com/aws/aws-sdk-go-v2/service/transfer v1.67.4
go: downloading github.com/aws/aws-sdk-go-v2/service/verifiedpermissions v1.29.9
go: downloading github.com/aws/aws-sdk-go-v2/service/vpclattice v1.19.4
go: downloading github.com/aws/aws-sdk-go-v2/service/waf v1.30.9
go: downloading github.com/aws/aws-sdk-go-v2/service/wafregional v1.30.10
go: downloading github.com/aws/aws-sdk-go-v2/service/wafv2 v1.68.4
go: downloading github.com/aws/aws-sdk-go-v2/service/wellarchitected v1.39.10
go: downloading github.com/aws/aws-sdk-go-v2/service/workmail v1.36.8
go: downloading github.com/aws/aws-sdk-go-v2/service/workspaces v1.64.2
go: downloading github.com/aws/aws-sdk-go-v2/service/workspacesweb v1.33.3
go: downloading github.com/aws/aws-sdk-go-v2/service/xray v1.36.9
go: downloading github.com/aws/aws-sdk-go-v2/internal/configsources v1.4.13
go: downloading github.com/aws/aws-sdk-go-v2/credentials v1.18.21
go: downloading github.com/aws/aws-sdk-go-v2/config v1.31.17
go: downloading github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.7.3
go: downloading github.com/aws/aws-sdk-go-v2/internal/v4a v1.4.13
go: downloading github.com/aws/aws-sdk-go-v2/service/internal/endpoint-discovery v1.11.13
go: downloading github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.19.13
go: downloading github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.13.3
go: downloading github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.9.4
go: downloading github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.13
go: downloading github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.20.4
go: downloading github.com/cedar-policy/cedar-go v1.3.0
go: downloading github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.7.13
go: downloading github.com/aws/aws-sdk-go-v2/service/ssooidc v1.35.5
2025/11/07 20:01:32 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/07 20:01:32 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccElastiCacheClusterDataSource_basic
=== PAUSE TestAccElastiCacheClusterDataSource_basic
=== RUN   TestAccElastiCacheClusterDataSource_Engine_Redis_LogDeliveryConfigurations
=== PAUSE TestAccElastiCacheClusterDataSource_Engine_Redis_LogDeliveryConfigurations
=== RUN   TestAccElastiCacheCluster_Engine_memcached
=== PAUSE TestAccElastiCacheCluster_Engine_memcached
=== RUN   TestAccElastiCacheCluster_Engine_redis
=== PAUSE TestAccElastiCacheCluster_Engine_redis
=== RUN   TestAccElastiCacheCluster_Engine_valkey
=== PAUSE TestAccElastiCacheCluster_Engine_valkey
=== RUN   TestAccElastiCacheCluster_disappears
=== PAUSE TestAccElastiCacheCluster_disappears
=== RUN   TestAccElastiCacheCluster_Engine_redis_v5
=== PAUSE TestAccElastiCacheCluster_Engine_redis_v5
=== RUN   TestAccElastiCacheCluster_Engine_None
=== PAUSE TestAccElastiCacheCluster_Engine_None
=== RUN   TestAccElastiCacheCluster_PortRedis_default
=== PAUSE TestAccElastiCacheCluster_PortRedis_default
=== RUN   TestAccElastiCacheCluster_ParameterGroupName_default
=== PAUSE TestAccElastiCacheCluster_ParameterGroupName_default
=== RUN   TestAccElastiCacheCluster_ipDiscovery
=== PAUSE TestAccElastiCacheCluster_ipDiscovery
=== RUN   TestAccElastiCacheCluster_port
=== PAUSE TestAccElastiCacheCluster_port
=== RUN   TestAccElastiCacheCluster_snapshotsWithUpdates
=== PAUSE TestAccElastiCacheCluster_snapshotsWithUpdates
=== RUN   TestAccElastiCacheCluster_NumCacheNodes_decrease
=== PAUSE TestAccElastiCacheCluster_NumCacheNodes_decrease
=== RUN   TestAccElastiCacheCluster_NumCacheNodes_increase
=== PAUSE TestAccElastiCacheCluster_NumCacheNodes_increase
=== RUN   TestAccElastiCacheCluster_NumCacheNodes_increaseWithPreferredAvailabilityZones
=== PAUSE TestAccElastiCacheCluster_NumCacheNodes_increaseWithPreferredAvailabilityZones
=== RUN   TestAccElastiCacheCluster_vpc
=== PAUSE TestAccElastiCacheCluster_vpc
=== RUN   TestAccElastiCacheCluster_multiAZInVPC
=== PAUSE TestAccElastiCacheCluster_multiAZInVPC
=== RUN   TestAccElastiCacheCluster_AZMode_memcached
=== PAUSE TestAccElastiCacheCluster_AZMode_memcached
=== RUN   TestAccElastiCacheCluster_AZMode_redis
=== PAUSE TestAccElastiCacheCluster_AZMode_redis
=== RUN   TestAccElastiCacheCluster_EngineVersion_memcached
=== PAUSE TestAccElastiCacheCluster_EngineVersion_memcached
=== RUN   TestAccElastiCacheCluster_EngineVersion_redis
=== PAUSE TestAccElastiCacheCluster_EngineVersion_redis
=== RUN   TestAccElastiCacheCluster_NodeTypeResize_memcached
=== PAUSE TestAccElastiCacheCluster_NodeTypeResize_memcached
=== RUN   TestAccElastiCacheCluster_NodeTypeResize_redis
=== PAUSE TestAccElastiCacheCluster_NodeTypeResize_redis
=== RUN   TestAccElastiCacheCluster_NumCacheNodes_redis
=== PAUSE TestAccElastiCacheCluster_NumCacheNodes_redis
=== RUN   TestAccElastiCacheCluster_ReplicationGroupID_availabilityZone
=== PAUSE TestAccElastiCacheCluster_ReplicationGroupID_availabilityZone
=== RUN   TestAccElastiCacheCluster_ReplicationGroupID_transitEncryption
=== PAUSE TestAccElastiCacheCluster_ReplicationGroupID_transitEncryption
=== RUN   TestAccElastiCacheCluster_ReplicationGroupID_singleReplica
=== PAUSE TestAccElastiCacheCluster_ReplicationGroupID_singleReplica
=== RUN   TestAccElastiCacheCluster_ReplicationGroupID_multipleReplica
=== PAUSE TestAccElastiCacheCluster_ReplicationGroupID_multipleReplica
=== RUN   TestAccElastiCacheCluster_Memcached_finalSnapshot
=== PAUSE TestAccElastiCacheCluster_Memcached_finalSnapshot
=== RUN   TestAccElastiCacheCluster_Redis_finalSnapshot
=== PAUSE TestAccElastiCacheCluster_Redis_finalSnapshot
=== RUN   TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade
=== PAUSE TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade
=== RUN   TestAccElastiCacheCluster_Engine_Redis_LogDeliveryConfigurations
=== PAUSE TestAccElastiCacheCluster_Engine_Redis_LogDeliveryConfigurations
=== RUN   TestAccElastiCacheCluster_tags
=== PAUSE TestAccElastiCacheCluster_tags
=== RUN   TestAccElastiCacheCluster_tagWithOtherModification
=== PAUSE TestAccElastiCacheCluster_tagWithOtherModification
=== RUN   TestAccElastiCacheCluster_TransitEncryption
=== PAUSE TestAccElastiCacheCluster_TransitEncryption
=== RUN   TestAccElastiCacheCluster_outpost_memcached
=== PAUSE TestAccElastiCacheCluster_outpost_memcached
=== RUN   TestAccElastiCacheCluster_outpost_redis
=== PAUSE TestAccElastiCacheCluster_outpost_redis
=== RUN   TestAccElastiCacheCluster_outpostID_memcached
=== PAUSE TestAccElastiCacheCluster_outpostID_memcached
=== RUN   TestAccElastiCacheCluster_outpostID_redis
=== PAUSE TestAccElastiCacheCluster_outpostID_redis
=== CONT  TestAccElastiCacheClusterDataSource_basic
=== CONT  TestAccElastiCacheCluster_ReplicationGroupID_availabilityZone
=== CONT  TestAccElastiCacheCluster_NumCacheNodes_decrease
=== CONT  TestAccElastiCacheCluster_NumCacheNodes_redis
=== CONT  TestAccElastiCacheCluster_NodeTypeResize_redis
=== CONT  TestAccElastiCacheCluster_NodeTypeResize_memcached
=== CONT  TestAccElastiCacheCluster_EngineVersion_redis
=== CONT  TestAccElastiCacheCluster_EngineVersion_memcached
=== CONT  TestAccElastiCacheCluster_AZMode_redis
=== CONT  TestAccElastiCacheCluster_Engine_None
--- PASS: TestAccElastiCacheCluster_Engine_None (2.26s)
=== CONT  TestAccElastiCacheCluster_AZMode_memcached
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_redis (2.50s)
=== CONT  TestAccElastiCacheCluster_multiAZInVPC
--- PASS: TestAccElastiCacheClusterDataSource_basic (597.66s)
=== CONT  TestAccElastiCacheCluster_vpc
--- PASS: TestAccElastiCacheCluster_AZMode_memcached (600.94s)
=== CONT  TestAccElastiCacheCluster_NumCacheNodes_increase
--- PASS: TestAccElastiCacheCluster_AZMode_redis (619.73s)
=== CONT  TestAccElastiCacheCluster_snapshotsWithUpdates
--- PASS: TestAccElastiCacheCluster_multiAZInVPC (703.06s)
=== CONT  TestAccElastiCacheCluster_ipDiscovery
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_decrease (878.53s)
=== CONT  TestAccElastiCacheCluster_ParameterGroupName_default
--- PASS: TestAccElastiCacheCluster_NodeTypeResize_memcached (1099.73s)
=== CONT  TestAccElastiCacheCluster_port
--- PASS: TestAccElastiCacheCluster_vpc (612.16s)
=== CONT  TestAccElastiCacheCluster_PortRedis_default
--- PASS: TestAccElastiCacheCluster_EngineVersion_memcached (1220.07s)
=== CONT  TestAccElastiCacheCluster_Engine_valkey
--- PASS: TestAccElastiCacheCluster_Engine_valkey (1.78s)
=== CONT  TestAccElastiCacheCluster_Engine_memcached
--- PASS: TestAccElastiCacheCluster_snapshotsWithUpdates (635.73s)
=== CONT  TestAccElastiCacheCluster_Engine_redis
--- PASS: TestAccElastiCacheCluster_ipDiscovery (615.91s)
=== CONT  TestAccElastiCacheCluster_NumCacheNodes_increaseWithPreferredAvailabilityZones
--- PASS: TestAccElastiCacheCluster_NodeTypeResize_redis (1361.19s)
=== CONT  TestAccElastiCacheCluster_tags
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_availabilityZone (1375.91s)
=== CONT  TestAccElastiCacheCluster_outpost_memcached
    cluster_test.go:1338: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpost_memcached (0.13s)
=== CONT  TestAccElastiCacheCluster_outpost_redis
    cluster_test.go:1378: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpost_redis (0.08s)
=== CONT  TestAccElastiCacheCluster_tagWithOtherModification
--- PASS: TestAccElastiCacheCluster_ParameterGroupName_default (569.35s)
=== CONT  TestAccElastiCacheCluster_outpostID_redis
    cluster_test.go:1451: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpostID_redis (0.08s)
=== CONT  TestAccElastiCacheCluster_Memcached_finalSnapshot
--- PASS: TestAccElastiCacheCluster_Memcached_finalSnapshot (2.11s)
=== CONT  TestAccElastiCacheCluster_Engine_redis_v5
--- PASS: TestAccElastiCacheCluster_port (589.67s)
=== CONT  TestAccElastiCacheCluster_outpostID_memcached
    cluster_test.go:1418: skipping since no Outposts found
--- SKIP: TestAccElastiCacheCluster_outpostID_memcached (0.13s)
=== CONT  TestAccElastiCacheCluster_Engine_Redis_LogDeliveryConfigurations
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_increase (1088.44s)
=== CONT  TestAccElastiCacheCluster_disappears
--- PASS: TestAccElastiCacheCluster_PortRedis_default (567.85s)
=== CONT  TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade
--- PASS: TestAccElastiCacheCluster_Engine_memcached (589.80s)
=== CONT  TestAccElastiCacheCluster_TransitEncryption
--- PASS: TestAccElastiCacheCluster_Engine_redis (579.70s)
=== CONT  TestAccElastiCacheCluster_ReplicationGroupID_singleReplica
--- PASS: TestAccElastiCacheCluster_tags (557.65s)
=== CONT  TestAccElastiCacheCluster_ReplicationGroupID_multipleReplica
--- PASS: TestAccElastiCacheCluster_Engine_redis_v5 (629.70s)
=== CONT  TestAccElastiCacheClusterDataSource_Engine_Redis_LogDeliveryConfigurations
--- PASS: TestAccElastiCacheCluster_disappears (598.01s)
=== CONT  TestAccElastiCacheCluster_ReplicationGroupID_transitEncryption
--- PASS: TestAccElastiCacheCluster_TransitEncryption (564.11s)
=== CONT  TestAccElastiCacheCluster_Redis_finalSnapshot
--- PASS: TestAccElastiCacheCluster_NumCacheNodes_increaseWithPreferredAvailabilityZones (1129.33s)
--- PASS: TestAccElastiCacheCluster_Redis_autoMinorVersionUpgrade (688.68s)
--- PASS: TestAccElastiCacheCluster_tagWithOtherModification (1371.04s)
--- PASS: TestAccElastiCacheCluster_Engine_Redis_LogDeliveryConfigurations (1133.71s)
--- PASS: TestAccElastiCacheClusterDataSource_Engine_Redis_LogDeliveryConfigurations (976.67s)
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_singleReplica (1304.27s)
--- PASS: TestAccElastiCacheCluster_Redis_finalSnapshot (787.60s)
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_multipleReplica (1367.67s)
--- PASS: TestAccElastiCacheCluster_ReplicationGroupID_transitEncryption (1395.20s)
--- PASS: TestAccElastiCacheCluster_EngineVersion_redis (4086.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	4086.883s


...

@sukumaar sukumaar requested a review from a team as a code owner November 10, 2025 15:56
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025 •
edited
Loading

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elasticache Issues and PRs that pertain to the elasticache service. size/S Managed by automation to categorize the size of a PR. labels Nov 10, 2025
@sukumaar sukumaar mentioned this pull request Nov 10, 2025
Open
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: AWS elasticache - Redis to Valkey migration

2 participants

@sukumaar @justinretzolk