Skip to content

Conversation

@grzegorzewald
Copy link

@grzegorzewald grzegorzewald commented Nov 12, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

There are certain issues with LakeFormation resources and catalog IDs being on top of S3Tables catalog. In after mentioned case catalog is not AWS account ID anymore, but has one of shapes:

  • AWS_ACCOUNT_ID
  • AWS_ACCOUNT_ID:s3tablescatalog
  • AWS_ACCOUNT_ID:s3tablescatalog/S3TABLES_BUCKET_NAME

Issue #44888 tried to resolve problem for LF Tagging by removing validation, although it shall extend it. Issue #40724 tackles similar issue for permissions grants.

Note, that AWS API does not accept pt new catalog ID structures in "top level" requests, only in "sub sections".

Description

A new validation function, ValidCatalogID, has been introduced. It has been used in for catalog_id fields validations.

Relations

Relates #44888
Closes #40724

Output from Acceptance Testing

$ make testacc PKG=lakeformation TESTS=TestAccLakeFormation_serial/ResourceLFTags
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 feat/lakeformation-s3tables-support 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run='TestAccLakeFormation_serial/ResourceLFTags'  -timeout 360m -vet=off
2025/11/12 10:02:43 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/12 10:02:43 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccLakeFormation_serial
=== PAUSE TestAccLakeFormation_serial
=== CONT  TestAccLakeFormation_serial
=== RUN   TestAccLakeFormation_serial/ResourceLFTags
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/database
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/databaseMultipleTags
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/disappears
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/hierarchy
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/table
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/tableWithColumns
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/basic
--- PASS: TestAccLakeFormation_serial (277.22s)
    --- PASS: TestAccLakeFormation_serial/ResourceLFTags (277.21s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/database (46.82s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/databaseMultipleTags (41.67s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/disappears (28.42s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/hierarchy (49.38s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/table (43.24s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/tableWithColumns (42.56s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/basic (25.12s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation      277.524s

@grzegorzewald grzegorzewald requested a review from a team as a code owner November 12, 2025 10:08
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lakeformation Issues and PRs that pertain to the lakeformation service. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) size/M Managed by automation to categorize the size of a PR. labels Nov 12, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Requests to existing resources that expand the functionality or scope. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: LakeFormation permissions for S3Tables Catalog

2 participants