Skip to content

Conversation

@gdavison
Copy link
Contributor

@gdavison gdavison commented Nov 12, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds region to ignored changes in aws_acmpca_certificate_authority Update. Prevents Either RevocationConfiguration or Status should be present validation errors when upgrading from pre-v6.0 provider versions without refreshing.

Output from Acceptance Testing

% make testacc PKG=acmpca TESTS=TestAccACMPCACertificateAuthority_

--- PASS: TestAccACMPCACertificateAuthority_deleteFromActiveState (90.37s)
--- PASS: TestAccACMPCACertificateAuthority_RevocationConfiguration_empty (117.46s)
--- PASS: TestAccACMPCACertificateAuthority_tags_DefaultTags_emptyResourceTag (122.71s)
--- PASS: TestAccACMPCACertificateAuthority_tags_DefaultTags_nullNonOverlappingResourceTag (127.03s)
--- PASS: TestAccACMPCACertificateAuthority_tags_DefaultTags_emptyProviderOnlyTag (127.06s)
--- PASS: TestAccACMPCACertificateAuthority_tags_DefaultTags_nullOverlappingResourceTag (135.09s)
--- FAIL: TestAccACMPCACertificateAuthority_enabledDeprecated (41.04s)
--- PASS: TestAccACMPCACertificateAuthority_Identity_Basic (168.00s)
--- PASS: TestAccACMPCACertificateAuthority_tags_EmptyTag_OnUpdate_Replace (180.02s)
--- PASS: TestAccACMPCACertificateAuthority_tags_DefaultTags_updateToResourceOnly (184.46s)
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_s3ObjectACL (188.17s)
--- PASS: TestAccACMPCACertificateAuthority_tags_DefaultTags_updateToProviderOnly (188.37s)
--- PASS: TestAccACMPCACertificateAuthority_tags_ComputedTag_OnUpdate_Replace (191.09s)
--- PASS: TestAccACMPCACertificateAuthority_tags_ComputedTag_OnUpdate_Add (192.89s)
--- PASS: TestAccACMPCACertificateAuthority_disappears (73.93s)
--- PASS: TestAccACMPCACertificateAuthority_usageMode (87.47s)
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_expirationInDays (230.68s)
--- PASS: TestAccACMPCACertificateAuthority_tags_IgnoreTags_Overlap_ResourceTag (258.55s)
--- PASS: TestAccACMPCACertificateAuthority_RevocationOcsp_enabled (265.97s)
--- PASS: TestAccACMPCACertificateAuthority_basic (79.02s)
--- PASS: TestAccACMPCACertificateAuthority_tags_null (135.22s)
--- PASS: TestAccACMPCACertificateAuthority_tags_DefaultTags_nonOverlapping (279.72s)
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_enabled (281.05s)
--- PASS: TestAccACMPCACertificateAuthority_tags_IgnoreTags_Overlap_DefaultTag (170.43s)
--- PASS: TestAccACMPCACertificateAuthority_tags_EmptyMap (107.38s)
--- PASS: TestAccACMPCACertificateAuthority_Identity_ExistingResource_NoRefresh_NoChange (103.86s)
--- PASS: TestAccACMPCACertificateAuthority_RevocationOcsp_customCNAME (292.62s)
--- PASS: TestAccACMPCACertificateAuthority_tags_ComputedTag_OnCreate (67.17s)
--- PASS: TestAccACMPCACertificateAuthority_tags_AddOnUpdate (118.70s)
--- PASS: TestAccACMPCACertificateAuthority_tags_EmptyTag_OnCreate (131.97s)
--- PASS: TestAccACMPCACertificateAuthority_tags_DefaultTags_overlapping (211.76s)
--- PASS: TestAccACMPCACertificateAuthority_RevocationCrl_customCNAME (306.00s)
--- PASS: TestAccACMPCACertificateAuthority_Identity_RegionOverride (93.16s)
--- PASS: TestAccACMPCACertificateAuthority_tags_EmptyTag_OnUpdate_Add (151.99s)
--- PASS: TestAccACMPCACertificateAuthority_Identity_ExistingResource (136.84s)
--- PASS: TestAccACMPCACertificateAuthority_tags (158.34s)
--- PASS: TestAccACMPCACertificateAuthority_tags_DefaultTags_providerOnly (157.57s)

TestAccACMPCACertificateAuthority_enabledDeprecated is a pre-existing failure

@gdavison gdavison requested a review from a team as a code owner November 12, 2025 23:57
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/acmpca Issues and PRs that pertain to the acmpca service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/XS Managed by automation to categorize the size of a PR. labels Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/acmpca Issues and PRs that pertain to the acmpca service. size/XS Managed by automation to categorize the size of a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant