Skip to content

Conversation

@ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 13, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds the missing region argument.
Requires resource identity schema migration.

As the resource can be imported, the undocumented id attribute changed from the AWS account ID to Region. I did not call this out in the CHANGELOG entry.

Relations

Closes #44250.
Relates #45023.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccEC2SerialConsoleAccess_serial' PKG=ec2   
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws_ec2_serial_console_access-add-region 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2SerialConsoleAccess_serial -timeout 360m -vet=off
2025/11/13 11:46:11 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/13 11:46:11 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccEC2SerialConsoleAccess_serial
=== PAUSE TestAccEC2SerialConsoleAccess_serial
=== CONT  TestAccEC2SerialConsoleAccess_serial
=== RUN   TestAccEC2SerialConsoleAccess_serial/Resource
=== RUN   TestAccEC2SerialConsoleAccess_serial/Resource/basic
=== RUN   TestAccEC2SerialConsoleAccess_serial/Resource/Identity
=== RUN   TestAccEC2SerialConsoleAccess_serial/Resource/Identity/UpgradeNoRefresh
=== RUN   TestAccEC2SerialConsoleAccess_serial/Resource/Identity/basic
=== RUN   TestAccEC2SerialConsoleAccess_serial/Resource/Identity/ExistingResource
=== RUN   TestAccEC2SerialConsoleAccess_serial/Resource/Identity/ExistingResourceNoRefresh
=== RUN   TestAccEC2SerialConsoleAccess_serial/Resource/Identity/RegionOverride
=== RUN   TestAccEC2SerialConsoleAccess_serial/Resource/Identity/Upgrade
=== RUN   TestAccEC2SerialConsoleAccess_serial/DataSource
=== RUN   TestAccEC2SerialConsoleAccess_serial/DataSource/basic
--- PASS: TestAccEC2SerialConsoleAccess_serial (304.69s)
    --- PASS: TestAccEC2SerialConsoleAccess_serial/Resource (295.56s)
        --- PASS: TestAccEC2SerialConsoleAccess_serial/Resource/basic (23.56s)
        --- PASS: TestAccEC2SerialConsoleAccess_serial/Resource/Identity (272.00s)
            --- PASS: TestAccEC2SerialConsoleAccess_serial/Resource/Identity/UpgradeNoRefresh (47.66s)
            --- PASS: TestAccEC2SerialConsoleAccess_serial/Resource/Identity/basic (20.13s)
            --- PASS: TestAccEC2SerialConsoleAccess_serial/Resource/Identity/ExistingResource (78.25s)
            --- PASS: TestAccEC2SerialConsoleAccess_serial/Resource/Identity/ExistingResourceNoRefresh (42.83s)
            --- PASS: TestAccEC2SerialConsoleAccess_serial/Resource/Identity/RegionOverride (24.33s)
            --- PASS: TestAccEC2SerialConsoleAccess_serial/Resource/Identity/Upgrade (58.80s)
    --- PASS: TestAccEC2SerialConsoleAccess_serial/DataSource (9.13s)
        --- PASS: TestAccEC2SerialConsoleAccess_serial/DataSource/basic (9.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	310.813s

@ewbankkit ewbankkit requested a review from a team as a code owner November 13, 2025 16:54
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 13, 2025
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/XL Managed by automation to categorize the size of a PR. labels Nov 13, 2025
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Nov 13, 2025
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ewbankkit ewbankkit merged commit d25c3f9 into main Nov 13, 2025
70 checks passed
@ewbankkit ewbankkit deleted the f-aws_ec2_serial_console_access-add-region branch November 13, 2025 17:40
@github-actions
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.21.0 milestone Nov 13, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Nov 13, 2025
@github-actions
Copy link
Contributor

This functionality has been released in v6.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing region argument of aws_ec2_serial_console_access resource

2 participants