Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hashicorp/go-plugin dependency #36561

Merged
merged 3 commits into from
Mar 26, 2025
Merged

Update hashicorp/go-plugin dependency #36561

merged 3 commits into from
Mar 26, 2025

Conversation

SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented Feb 21, 2025 •
edited
Loading

Pulling in this vulnerability fix:

See comparison : compare/v1.6.0..v1.6.3

The change in how code is generate from the .proto files is due to hashicorp/go-plugin upgrading these:

-	google.golang.org/grpc v1.38.0
-	google.golang.org/protobuf v1.28.2-0.20230222093303-bc1253ad3743
+	google.golang.org/grpc v1.58.3
+	google.golang.org/protobuf v1.36.1

Target Release

1.11.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@SarahFrench SarahFrench added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Feb 21, 2025
@SarahFrench SarahFrench marked this pull request as ready for review February 21, 2025 14:08
@SarahFrench SarahFrench requested review from a team as code owners February 21, 2025 14:08
@SarahFrench SarahFrench added the 1.11-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Feb 21, 2025
@SarahFrench SarahFrench marked this pull request as draft February 21, 2025 14:11
@SarahFrench
Copy link
Member Author

SarahFrench commented Feb 21, 2025 •
edited
Loading

Marking as draft because there was an issue with generated files.

In response I:

  • Ran make generate => no diffs
  • Ran make protobuf => committed diffs

@SarahFrench SarahFrench marked this pull request as ready for review February 21, 2025 14:21
@SarahFrench SarahFrench force-pushed the sarah/update-deps-2025-02-21 branch from 63e1996 to 330caf9 Compare March 3, 2025 11:28
@SarahFrench SarahFrench changed the title Bump cli and go-plugin dependencies Bump go-plugin dependency Mar 3, 2025
@SarahFrench SarahFrench changed the title Bump go-plugin dependency Update hashicorp /go-plugin dependency Mar 3, 2025
@SarahFrench SarahFrench changed the title Update hashicorp /go-plugin dependency Update hashicorp/go-plugin dependency Mar 3, 2025
@SarahFrench SarahFrench force-pushed the sarah/update-deps-2025-02-21 branch from 330caf9 to 6380260 Compare March 26, 2025 12:03
@SarahFrench SarahFrench removed the 1.11-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Mar 26, 2025
@SarahFrench
Copy link
Member Author

Note: first commit should have been called go get github.com/hashicorp/go-plugin - was a victim of a rebase

@SarahFrench SarahFrench enabled auto-merge (squash) March 26, 2025 12:07
@SarahFrench SarahFrench merged commit a04664a into main Mar 26, 2025
8 of 9 checks passed
@SarahFrench SarahFrench deleted the sarah/update-deps-2025-02-21 branch March 26, 2025 12:09
rkoron007 pushed a commit that referenced this pull request Mar 27, 2025
@SarahFrench @rkoron007
Update hashicorp/go-plugin dependency (#36561)
61654e4 
* go get github.com/hashicorp/go-plugin

* ./scripts/syncdeps.sh

* make protobuf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamcervante liamcervante liamcervante approved these changes

Assignees
No one assigned
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SarahFrench @liamcervante