stacks: emit state updates for unclaimed components #36702
Merged
+108
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamcervante
added
the
no-changelog-needed
…te/stacks/removed-unknown-apply
dsa0x
approved these changes
Mar 18, 2025
nfagerlund
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the internal logic of the apply operation of stacks so that it will emit proper error messages for certain internal inconsistencies. Also, we will now publish component updates for "unclaimed" instances, which are instances that are in state already but were deferred for other reasons.
This PR should hopefully resolve some inconsistent behaviour in the plan / apply cycle with more explicit error messages for failure cases, and state updates for everything concrete that was in the plan.