Terraform Test: Allow skipping cleanup of entire test file or individual run blocks #36729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsa0x
added
the
no-changelog-needed
dsa0x
force-pushed
the
sams/test_skip_cleanup
branch
from
f121f50 to
88896d6
Compare
dsa0x
force-pushed
the
sams/test_skip_cleanup
branch
from
88896d6 to
7f4cb14
Compare
SarahFrench
reviewed
Mar 21, 2025
SarahFrench
reviewed
Mar 25, 2025
There was a problem hiding this comment.
Left a few comments:
- Some nit-like comments about how terminal output could make it clearer about whether cleanup is being skipped, and why.
- A comment about some scenarios with conflicting skip_cleanup instructions that it might be useful to add tests for.
In the case of conflicting skip_cleanup instructions from run blocks versus the test block, should that cause a parsing error or should the test run and during cleanup users see a warning about the conflicting instructions?
dsa0x
force-pushed
the
sams/test_skip_cleanup
branch
from
ef3d3a7 to
7121af8
Compare
SarahFrench
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
skip_cleanup, which allows skipping the cleanup of individual run blocks or the entire test file. This simply ensures that the cleanup stage for the state is an apply of the run requesting the skip, instead of the normal destroyTarget Release
1.12.x
CHANGELOG entry