-
Notifications
You must be signed in to change notification settings - Fork 133
VSO Event Notifications for Dynamic Secrets #1146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/vso-event-notifications-dynamic-secrets
Are you sure you want to change the base?
VSO Event Notifications for Dynamic Secrets #1146
Conversation
3c8ce0f to
0068246
Compare
…-updates-database-secrets' into VAULT-40343/instant-updates-database-secrets
…-updates-database-secrets' into VAULT-40343/instant-updates-database-secrets
tvoran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the example logs it looks like this is responding to credential generation and rotate-root. I think for dynamic secrets, this should really only care about lease revocation? Like if the lease for the dynamic credentials was revoked on the Vault side.
The credentials were generated by VSO, and IIRC it would've already re-queued the VDS object based on the ttl of the lease, so I don't think VSO should respond to that event. And I'm not following why VSO would want to react to the root credentials being rotated, since those are what Vault uses to connect to the database, and not a secret VSO would have access to.
Co-authored-by: Theron Voran <[email protected]>
…-updates-database-secrets' into VAULT-40343/instant-updates-database-secrets
Description
This PR adds the
syncConfig.insantUpdatesoption toVaultDynamicSecret. When enabled, Vault will send event notifications to Vault Secrets Operator. This will be used to update on a near-immediate basis when secret information when the secret is updated in Vault. This PR adds the basic event notification skeleton code so that VSO can be aware of secret events. Responding to these secret events will be added in future PRs.Jira Ticket
https://hashicorp.atlassian.net/browse/VAULT-40801
Testing
Set up connection to kubernetes and database secret in Vault
Set up authentication with kubernetes and created a database secret in Vault
Database Secret script file
Create VaultConnection Resource
Click to expand VaultConnection resources
Create VaultAuth Resource
Click to expand VaultAuth resource
Create VaultDynamicSecret Resource
Click to expand VaultDynamicSecret resource
Attempted a manual rotation of the database secret and confirmed that the websocket logged the connection in the logs of VSO
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.