Add docs for plugins with enterprise scheduled root rotation feature #29608
+244
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
fairclothjm
reviewed
Feb 21, 2025
|
|
||
| ```shell-session | ||
| $ vault write auth/azure/config \ | ||
| rotation_schedule="0 * * * SAT" |
There was a problem hiding this comment.
Should we make it more obvious that this is not a complete example of configuring the mount? Something like ellipses maybe?
Suggested change
| rotation_schedule="0 * * * SAT" | |
| rotation_schedule="0 * * * SAT" | |
| # ... |
There was a problem hiding this comment.
We can, although this is also acceptable as a configuration to send, assuming you've already configured the backend.
There was a problem hiding this comment.
i added ellipses to the example requests to indicate that more fields can/should exist if needed/appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds documentation for three plugins with the new scheduled root rotation enterprise feature
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.in the PR description, commit message, or branch name.