Small fixes on UX of Automated Root Rotation parameters #29685
+131
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
vinay-gopalan
added
pr/no-changelog
and removed
hashicorp-contributed-pr
vinay-gopalan
requested review from
kpcraig and
robmonte
and removed request for
pmmukh
|
CI Results: |
|
Build Results: |
github-actions
bot
added
the
hashicorp-contributed-pr
kpcraig
reviewed
Feb 21, 2025
| @@ -43,7 +44,8 @@ func TestBackend_PathConfigRoot(t *testing.T) { | |||
| "identity_token_audience": "", | |||
| "identity_token_ttl": int64(0), | |||
| "rotation_schedule": "", | |||
| "rotation_window": 0, | |||
| "rotation_period": time.Duration(0).Seconds(), | |||
There was a problem hiding this comment.
Is there a way to write this test so we can show it accepting a string format duration?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small fixes around the usability of the new automated root rotation parameters added to select Secret and Auth engines for 1.19 Enterprise.
This PR:
rotation_periodandrotation_windowto be duration strings instead of just integers to be consistent with static role mechanismsrotation_period— which would first de-register — and then setrotation_schedulein a follow up call to re-register)disable_automated_rotationwas not passed in a request, it was treated as being set tofalse, which would cause a de-registration. Now it will only de-register if the param is explicitly set tofalseAutomatedRotationParamsstruct in the DB Config read methodrotation_periodandrotation_windowto 0, which was causing unnecessary errors)