-
Notifications
You must be signed in to change notification settings - Fork 103
Docs Process: Add TW processes and docs contributor guide DRAFT #1117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Vercel Previews Deployed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This review was me going through this PR at a high level and leaving some initial notes that are as much for me as they are for you. I'm going to checkout the branch and make some commits directly, per your suggestion, to speed up the process.
docs/contribute.md
Outdated
|
|
||
| ### Workflows | ||
|
|
||
| @TODO use which presentation?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List, but get rid of the sentence after the colon, and make each item a link to the workflow.
| --- | ||
| ``` | ||
|
|
||
| This repository's content guide includes detailed instructions on how to [create a new page and add it to the navigation sidebar](/content--guide/create-new-page). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This repository's content guide includes detailed instructions on how to [create a new page and add it to the navigation sidebar](/content--guide/create-new-page). | |
| This repository's content guide includes detailed instructions on how to [create a new page and add it to the navigation sidebar](/content-guide/create-new-page). |
fix link
|
|
||
| In our documentation, you can use custom markdown enhancements to produce pages with tabs, named code blocks, badges, and alert boxes. | ||
|
|
||
| Correct usage of these enhancements is documented in this repo's [content style guide](/style-guide). The custom components and additional configuration options are avaialble using the `dev-portal` repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Correct usage of these enhancements is documented in this repo's [content style guide](/style-guide). The custom components and additional configuration options are avaialble using the `dev-portal` repo. | |
| Correct usage of these enhancements is documented in this repo's [content style guide](/style-guide). |
Suggest removing "The custom...." sentence. Content contributors don't need to know the DevDot underlying architecture in order to use the custom components, and this sentence makes me think I might have to do something with the dev-portal project in order to use custom components.
|
|
||
| ## Navigation sidebars | ||
|
|
||
| The structure of the sidebars are controlled by files in the `./content/<product>/<version>/<data>` directory. Each file contains a configuration for a section of product documentation. For example, `docs-nav-data.json` controls navigation in the product's `Documentation` section on developer.hashicorp.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The structure of the sidebars are controlled by files in the `./content/<product>/<version>/<data>` directory. Each file contains a configuration for a section of product documentation. For example, `docs-nav-data.json` controls navigation in the product's `Documentation` section on developer.hashicorp.com. | |
| The structure of the sidebars is controlled by files in the `./content/<product>/<version>/<data>` directory. Each file contains a configuration for a section of product documentation. For example, `docs-nav-data.json` controls navigation in the product's `Documentation` section on developer.hashicorp.com. |
|
|
||
| Correct usage of these enhancements is documented in this repo's [content style guide](/style-guide). The custom components and additional configuration options are avaialble using the `dev-portal` repo. | ||
|
|
||
| ## Navigation sidebars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to duplicate this here when it's in the create-new-page file? Probably safe to say that the majority of contributors aren't going to be modifying the sidebar files. Potentially less confusing to keep all the sidebar content with the create new page content.
| - An `index.mdx` file is not required for each subdirectory. | ||
| - If you use `index.mdx` files: you must add the file to the navigation `.json`, but the `.json` file can resolve it from the name of the directory. In the example, notice that it uses the `directory` path rather than `directory/index`. A common convention is to set the `title` of an index node to be `"Overview"`. | ||
|
|
||
| ### Custom or external links |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest moving this section to create-new-page file.
|
|
||
| ## Redirects | ||
|
|
||
| Detailed guidance on redirects and formatting is available in the [content guide](/content-guide/redirects). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Detailed guidance on redirects and formatting is available in the [content guide](/content-guide/redirects). | |
| Find detailed guidance on redirects and formatting in the [content guide](/content-guide/redirects). |
active voice
Co-authored-by: Jeff Boruszak <[email protected]>
Jira: CE-1062
I copied content from Confluence wikis TW content types, web-unified-docs reference, How to contribute to Vault docs and sidebar explanation from nomad/website/README.
Previews: