nomad: clarify lost_after default and fix conflicting statements #1460
+16
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d fix conflicting statements
mismithhisler
commented
Dec 4, 2025
| disconnected. | ||
|
|
||
| - `stop_on_client_after` `(string: "")` - Specifies a duration after which a | ||
| disconnected Nomad client will stop its allocations. Setting |
Member
Author
There was a problem hiding this comment.
Removing this because it implies these two settings can be set at the same time, however they cannot, and that is mentioned in several places in the docs.
Contributor
Vercel Previews Deployed
|
Contributor
Broken Link CheckerNo broken links found! 🎉 |
mismithhisler
commented
Dec 8, 2025
| [drain]: /nomad/commands/node/drain | ||
| [deadline]: /nomad/commands/node/drain#deadline | ||
| [replaces]: /nomad/docs/job-specification/disconnect#replace | ||
| [replaces]: /nomad/docs/job-specification/disconnect |
Member
Author
There was a problem hiding this comment.
Linking to the replace parameter was misleading, so instead, just link to the disconnect overview.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please go to the
Previewtab and select the appropriate template:Terraform
Currently in Draft until hashicorp/nomad#27053 is reviewed, which fixes some disconnect.lost_after and disconnect.replace behavior.