-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cfgVerbosity #10688
Open
philderbeast
wants to merge
3
commits into
haskell:master
Choose a base branch
from
cabalism:add/cfg-verbosity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add cfgVerbosity #10688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d33d578
to
a0bfc7d
Compare
6d41621
to
5a0e55b
Compare
9241039
to
a4848dc
Compare
ffaf1
reviewed
Jan 16, 2025
Comment on lines
+5
to
+6
Configuration is affected by the following files: | ||
- cabal.project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this appearing twice in the output?
d70b9d8
to
d58c3c0
Compare
d58c3c0
to
ec02235
Compare
ec02235
to
b2f50b6
Compare
Kleidukos
approved these changes
Feb 27, 2025
b2f50b6
to
085e216
Compare
geekosaur
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on a fix for #10527 and noticed that all but one of the callers of
withContextAndSelectors
had already accessed verbosity in the same way thatwithContextAndSelectors
does (Cmd*.hs
modules do this):cabal/cabal-install/src/Distribution/Client/CmdRepl.hs
Line 509 in 62073c9
cabal/cabal-install/src/Distribution/Client/ScriptUtils.hs
Line 340 in 62073c9
This is a refactor that adds a verbosity argument to
withContextAndSelectors
and a functioncfgVerbosity
that simplifies grabbing the verbosity from the configuration or using a default value.With this a lot of
-XRecordWildCards
can be removed as can a lot of imports fromDistribution.Client.Setup
.This will help with my fix for #10527 too as I may have to call
withContextAndSelectors
twice1 and don't want repeated messaging so would silence the verbosity of the first call.Footnotes
Depending on whether
cabal repl
should pick the one target, Shouldcabal repl
pick the one package library as TARGET? #10689. ↩