Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(mergify): upgrade configuration to current format #10879

Merged
merged 2 commits into from
Apr 13, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 28, 2025

Hey there! 👋

We've noticed that your Mergify configuration is using some deprecated fields.

No worries—we've got your back! This automated PR updates your config to align with the newest standards, ensuring everything keeps running smoothly.

Do not procrastinate! You must upgrade your configuration before 2025-06-30, otherwise your configuration will stop working.

What's Changed?

  • The implicit priority for the queue rules, that was based on their order, is going to be removed in favor of using priority_rules.
    This transformation aim to create priority rules, based on your existing queue rules, in order to keep the same priorities. If this priority change is not needed for you, you should not close this pull request until the deadline, otherwise it will be re-created again. (deadline: 2025-06-30)

Why This Matters

Keeping your configuration up-to-date means you'll benefit from the latest features and improvements Mergify has to offer. Plus, it helps prevent any unexpected hiccups down the road.

Got Questions? We've Got Answers! 🙌

Is this update safe to merge?

Absolutely! We've made sure the changes are compatible with your current setup. Your workflows should continue to work just as before—if not better!

Do I need to do anything special after merging?

Nope! Just merge this PR, and you're all set. If you have any custom configurations, it's a good idea to give them a quick look to ensure everything's in order.

What if I run into issues or have concerns?

We're here to help! Feel free to reach out to our support team anytime.

Thanks for being awesome and keeping your configuration up-to-date! If you have any thoughts or need a hand, don't hesitate to let us know.

Happy merging! 🎉

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superficially, this looks fine to me.

@ulysses4ever ulysses4ever requested a review from geekosaur March 28, 2025 16:57
@geekosaur
Copy link
Collaborator

This actually has a problem: it somehow missed that we have two queues (default and squash-merge) and doesn't set the priority for the latter. I will fix.

@Mikolaj
Copy link
Member

Mikolaj commented Mar 28, 2025

This won't be backported, right? 3.14 is not LTS for sure.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch, @geekosaur , thanks!

@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Mar 28, 2025

but if we'll want another point release, we might need it. For the current one, we might skip it for expediency?..

@geekosaur
Copy link
Collaborator

It's Mergify config, it does nothing whatsoever on branches. Mergify only pays attention to master.

@ulysses4ever
Copy link
Collaborator

allrighty!

@ulysses4ever ulysses4ever requested a review from Mikolaj March 28, 2025 19:12
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mikolaj
Copy link
Member

Mikolaj commented Apr 10, 2025

@geekosaur: you are the CI guru, would you set the merge label?

@geekosaur geekosaur added the merge me Tell Mergify Bot to merge label Apr 10, 2025
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Apr 10, 2025
@Mikolaj Mikolaj force-pushed the mergify/configuration-deprecated-update branch from 1ecc206 to a1a88ca Compare April 12, 2025 18:03
Copy link
Contributor Author

mergify bot commented Apr 13, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot merged commit db7af8a into master Apr 13, 2025
57 checks passed
@mergify mergify bot deleted the mergify/configuration-deprecated-update branch April 13, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants