Skip to content

multi-repl: Support module renaming for ghc-9.12 onwards #10880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025
Merged

Conversation

mpickering
Copy link
Collaborator

In ghc-9.12 the -rexported-module flag was extended to add support for module renaming.

Therefore now if a module uses a module renaming, then the -reexported-module flag is passed the renaming.

Fixes #10181

Please read Github PR Conventions and then fill in one of these two templates.


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@mpickering
Copy link
Collaborator Author

Fixed the test being run with a GHC version which doesn't support multi-repl at all.

@Mikolaj
Copy link
Member

Mikolaj commented May 8, 2025

@mpickering: let me take the liberty of setting the review-needed label.

@mpickering
Copy link
Collaborator Author

Two weeks and no reviews, can I merge this patch? I am confident it's correct.

@geekosaur
Copy link
Collaborator

We still require reviews. The past two weeks have just been roughly the worst possible time to get me to do reviews, though. 😖

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpickering mpickering added the merge me Tell Mergify Bot to merge label Jun 12, 2025
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Jun 12, 2025
mergify bot added a commit that referenced this pull request Jun 14, 2025
Copy link
Contributor

mergify bot commented Jun 14, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #10987.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

In ghc-9.12 the -rexported-module flag was extended to add support for
module renaming.

Therefore now if a module uses a module renaming, then the
-reexported-module flag is passed the renaming.

Fixes #10181
@mergify mergify bot merged commit 4200116 into master Jun 14, 2025
55 checks passed
@mergify mergify bot deleted the wip/10181 branch June 14, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-repl doesn't support renaming of reexported modules
4 participants