-
Notifications
You must be signed in to change notification settings - Fork 719
multi-repl: Support module renaming for ghc-9.12 onwards #10880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed the test being run with a GHC version which doesn't support multi-repl at all. |
@mpickering: let me take the liberty of setting the review-needed label. |
Two weeks and no reviews, can I merge this patch? I am confident it's correct. |
We still require reviews. The past two weeks have just been roughly the worst possible time to get me to do reviews, though. 😖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #10987. You may have to fix your CI before adding the pull request to the queue again. |
In ghc-9.12 the -rexported-module flag was extended to add support for module renaming. Therefore now if a module uses a module renaming, then the -reexported-module flag is passed the renaming. Fixes #10181
In ghc-9.12 the -rexported-module flag was extended to add support for module renaming.
Therefore now if a module uses a module renaming, then the -reexported-module flag is passed the renaming.
Fixes #10181
Please read Github PR Conventions and then fill in one of these two templates.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significant
in the changelog file.Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: