Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building foreign libraries on FreeBSD #10907

Merged
merged 1 commit into from
Apr 13, 2025
Merged

Conversation

arrowd
Copy link
Collaborator

@arrowd arrowd commented Apr 5, 2025

Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW we can't currently test on FreeBSD (I hope to get validate running on CircleCI at some point).

@arrowd
Copy link
Collaborator Author

arrowd commented Apr 6, 2025

I bumped into this problem on FreeBSD, patched our Cabal port and verified that it works: freebsd/freebsd-ports@2c0ada2

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Feel free to set the merge_me label.

@arrowd arrowd added the merge me Tell Mergify Bot to merge label Apr 10, 2025
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Apr 10, 2025
Copy link
Contributor

mergify bot commented Apr 13, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Copy link
Contributor

mergify bot commented Apr 13, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@arrowd
Copy link
Collaborator Author

arrowd commented Apr 13, 2025

What do I need to do to tame the bot?

@ulysses4ever
Copy link
Collaborator

@arrowd sorry for the bot. Could you please try to rebase one more time maybe? On the top of the latest master.

@mergify mergify bot merged commit 703582f into haskell:master Apr 13, 2025
53 checks passed
@ulysses4ever
Copy link
Collaborator

Terrific, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants