-
Notifications
You must be signed in to change notification settings - Fork 709
Drop the dead build-tool greencard #10908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do we care? 7.10 doesn't even run on modern Linux, I think. |
My old 2015 Mac can do 7.10 but my new Mac comfortably only supports 9.2 and up. My only worries are about the revision process on |
I can see that, but my point was more that such revisions seem extremely unlikely to come up. |
3faf965
to
46ed72d
Compare
This tool does not build with GHC 7.10 and up, so can be considered dead by now. Cabal will now pretend it never knew about `greencard`. I am not sure of the repercussions of this, e.g. when we want to revise a package on hackage that uses `build-tools: greencard`, will the parser or checker blow up on us?
46ed72d
to
881d434
Compare
I have added a changelog entry now. So this PR is ready! |
Another thing: old config files that have entries for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 Spring cleaning! 🚨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, the effort needed to make this particular breakage less abrupt would be better spent elsewhere, so this seems fine.
Did we actually check that Hackage won't fail to parse? And configurations? |
We also might consider this opportunity to remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just "request changes" to make sure this doesn't merge without an answer to the questions above.
#10912 covers first and third @jasagredo |
Yes, you get a warning like
I think "no" because any executable is allowed under
Actually all three. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification
The
greencard
tool does not build with GHC 7.10 and up, so can be considered dead by now.Cabal will now pretend it never knew about
greencard
.I am not sure of the repercussions of this, e.g. when we want to revise a package on hackage that uses
build-tools: greencard
, will the parser or checker blow up on us?