Skip to content

Drop the dead build-tool greencard #10908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025
Merged

Drop the dead build-tool greencard #10908

merged 3 commits into from
Apr 9, 2025

Conversation

andreasabel
Copy link
Member

@andreasabel andreasabel commented Apr 5, 2025

The greencard tool does not build with GHC 7.10 and up, so can be considered dead by now.

Cabal will now pretend it never knew about greencard.
I am not sure of the repercussions of this, e.g. when we want to revise a package on hackage that uses build-tools: greencard, will the parser or checker blow up on us?

@geekosaur
Copy link
Collaborator

Do we care? 7.10 doesn't even run on modern Linux, I think.

@andreasabel
Copy link
Member Author

My old 2015 Mac can do 7.10 but my new Mac comfortably only supports 9.2 and up.

My only worries are about the revision process on hackage-server which uses Cabal the library.

@andreasabel andreasabel marked this pull request as draft April 5, 2025 20:52
@geekosaur
Copy link
Collaborator

I can see that, but my point was more that such revisions seem extremely unlikely to come up.

This tool does not build with GHC 7.10 and up, so can be considered
dead by now.

Cabal will now pretend it never knew about `greencard`.
I am not sure of the repercussions of this, e.g. when we want to
revise a package on hackage that uses `build-tools: greencard`, will
the parser or checker blow up on us?
@andreasabel andreasabel marked this pull request as ready for review April 6, 2025 17:48
@andreasabel andreasabel added attention: needs-review re: build-tool Concerning `build-tools` and `build-tool-depends` labels Apr 6, 2025
@andreasabel
Copy link
Member Author

I have added a changelog entry now. So this PR is ready!

@andreasabel
Copy link
Member Author

Another thing: old config files that have entries for greencard-options etc., do they fail to parse now or are these unrecognized fields ignored with a warning?
(Maybe this is also a hypothetical case...)

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Spring cleaning! 🚨

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, the effort needed to make this particular breakage less abrupt would be better spent elsewhere, so this seems fine.

@andreasabel andreasabel added squash+merge me Tell Mergify Bot to squash-merge and removed attention: needs-review labels Apr 7, 2025
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Apr 7, 2025
@jasagredo
Copy link
Collaborator

Did we actually check that Hackage won't fail to parse? And configurations?

@jasagredo
Copy link
Collaborator

We also might consider this opportunity to remove haskell-suite, haskell-suite-pkg and hmake.

Copy link
Collaborator

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just "request changes" to make sure this doesn't merge without an answer to the questions above.

@ulysses4ever
Copy link
Collaborator

We also might consider this opportunity to remove haskell-suite, haskell-suite-pkg and hmake.

#10912 covers first and third @jasagredo

@andreasabel
Copy link
Member Author

andreasabel commented Apr 7, 2025

unrecognized fields ignored with a warning?

Yes, you get a warning like Unrecognized field greencard-location on line NNN.

when we want to revise a package on hackage that uses build-tools: greencard, will the parser or checker blow up on us?

I think "no" because any executable is allowed under build-tools:, in particular, greencard will not lead to a parse error.

We also might consider this opportunity to remove haskell-suite, haskell-suite-pkg and hmake.

#10912 covers first and third @jasagredo

Actually all three.

@andreasabel andreasabel requested a review from jasagredo April 7, 2025 14:34
Copy link
Collaborator

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Apr 9, 2025
@mergify mergify bot merged commit 1b301a4 into master Apr 9, 2025
55 checks passed
@mergify mergify bot deleted the remove-greencard branch April 9, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days re: build-tool Concerning `build-tools` and `build-tool-depends` ready and waiting Mergify is waiting out the cooldown period squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants