Skip to content

pass ghc-options when compiling js, Cmm or asm #10949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025
Merged

Conversation

zlonast
Copy link
Collaborator

@zlonast zlonast commented May 8, 2025

The PR fixes the comment (#10721) by adding a new ghc-options to js, cmm, asm.

Template Α: This PR modifies behaviour or interface

@zlonast zlonast force-pushed the master branch 2 times, most recently from d10a269 to afb916c Compare May 8, 2025 18:43
@zlonast
Copy link
Collaborator Author

zlonast commented May 8, 2025

I still can't figure out what's wrong with UntrimmedImport in some versions of ghc

@zlonast zlonast force-pushed the master branch 4 times, most recently from afb916c to d6b3ccc Compare May 11, 2025 08:33
@zlonast zlonast requested a review from geekosaur May 11, 2025 12:10
@zlonast
Copy link
Collaborator Author

zlonast commented May 11, 2025

@ulysses4ever @Mikolaj 👀

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I'm not qualified to judge all possible revelations from this change, but I want to unblock it. In any case, we'll have the two-day delay as usual, so I hope more people will have a chance to look through it before it's merged.

Thank you for your contribution!

Copy link
Collaborator

@hsyl20 hsyl20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not qualified to judge the implications of this change. There is no spec so who knows what is supposed to be happening. But if @phadej is right in his comment, then the patch looks correct to me too. So approved.

@mpickering
Copy link
Collaborator

This seems right, but missing a changelog entry.

@zlonast
Copy link
Collaborator Author

zlonast commented May 16, 2025

A small reminder that initially I needed flags for js, if there are any qualifying difficulties with asm and cmm, then I am ready to make a concession :)

@Mikolaj
Copy link
Member

Mikolaj commented May 16, 2025

@zlonast: just a reminder: this now has 2 or more reviews, so it's your call to set a merge label, which will merge this PR in 2 days. Let us know if you can't set the label.

@zlonast
Copy link
Collaborator Author

zlonast commented May 16, 2025

@zlonast: just a reminder: this now has 2 or more reviews, so it's your call to set a merge label, which will merge this PR in 2 days. Let us know if you can't set the label.

I can't set a label

@Mikolaj
Copy link
Member

Mikolaj commented May 16, 2025

Apologies, can you try now?

@zlonast
Copy link
Collaborator Author

zlonast commented May 16, 2025

Apologies, can you try now?

Nothing has changed, look who can set them, maybe it's the members?

@zlonast zlonast added the merge me Tell Mergify Bot to merge label May 16, 2025
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels May 16, 2025
Copy link
Contributor

mergify bot commented May 18, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

add GhcOptions test

partial fix for haskell#10721
@mergify mergify bot merged commit 96ce5a8 into haskell:master May 18, 2025
54 checks passed
@ulysses4ever ulysses4ever changed the title If ghc-options is not passed when compiling js, Cmm or asm, that's a bug pass ghc-options when compiling js, Cmm or asm May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants