-
Notifications
You must be signed in to change notification settings - Fork 710
pass ghc-options when compiling js, Cmm or asm #10949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d10a269
to
afb916c
Compare
I still can't figure out what's wrong with |
afb916c
to
d6b3ccc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like I'm not qualified to judge all possible revelations from this change, but I want to unblock it. In any case, we'll have the two-day delay as usual, so I hope more people will have a chance to look through it before it's merged.
Thank you for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not qualified to judge the implications of this change. There is no spec so who knows what is supposed to be happening. But if @phadej is right in his comment, then the patch looks correct to me too. So approved.
This seems right, but missing a changelog entry. |
A small reminder that initially I needed flags for js, if there are any qualifying difficulties with asm and cmm, then I am ready to make a concession :) |
@zlonast: just a reminder: this now has 2 or more reviews, so it's your call to set a merge label, which will merge this PR in 2 days. Let us know if you can't set the label. |
I can't set a label |
Apologies, can you try now? |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
add GhcOptions test partial fix for haskell#10721
The PR fixes the comment (#10721) by adding a new ghc-options to js, cmm, asm.
Template Α: This PR modifies behaviour or interface
Manual QA notes have been included.