Fix typo explitic

[philderbeast]

A follow on from #11501. This changes a couple of data constructors in Cabal.

---

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
  • Is the change significant? If so, remember to add significance: significant in the changelog file.
• The documentation has been updated, if necessary.
• Manual QA notes have been included.
• Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

[geekosaur]

It has (finally) occurred to me to wonder if we can define bidirectional pattern synonyms with the old names for constructors like this, and mark them as deprecated so users get warnings. We might then remove them in 3.20. I won't block the PR on that, though.

[philderbeast]

define bidirectional pattern synonyms with the old names for constructors like this, and mark them as deprecated so users get warnings.

That's possible but I don't think the effort is worth it. I searched GitHub for the typo "CVExpliticDepsCustomSetup" and the only hits were in forks of haskell/cabal. Same goes searching for "CICVExpliticDepsCustomSetup". Within haskell/cabal itself, this constructor is only used within the function:

cabal/Cabal/src/Distribution/PackageDescription/Check.hs

Line 393 in 449d2ef

checkPackageDescription :: Monad m => PackageDescription -> CheckM m ()

[philderbeast]

I won't block the PR on that, though.

Thanks @geekosaur.