merge queue: embarking master (beba231), #11450 and #11386 together#11624
Closed
mergify[bot] wants to merge 4 commits intomasterfrom
Closed
merge queue: embarking master (beba231), #11450 and #11386 together#11624mergify[bot] wants to merge 4 commits intomasterfrom
mergify[bot] wants to merge 4 commits intomasterfrom
Conversation
The new `Cabal` and `cabal-install` option tells GHC to build a bytecode library. * When GHC is invoked, bytecode objects are also produced. * A bytecode library is created during linking. * The bytecode library is installed when the package is installed. * The `bytecode-library-dirs` field can be populated to instruct GHC where to find the bytecode library for a package. (This can be useful if the bytecode libraries are distributed separately from the other libraries). * The `--bytecodelibdir` option can be used to specify a separate install location for bytecode libraries. The bytecode object files are produced alongside an existing build way. They are prioritised in this order (`-dyn-too`, `-dynamic`, `-static`). Bytecode libraries can't be produced standalone at the moment. You have to produce them alongside an existing build way. This is due to limitations in GHC. At the moment, there is not support implemented for creating profiled bytecode libraries. Implements haskell/cabal-proposals#2 Fixes #11188
The cause of this bug was when ProgramDb is serialised (by caching), the `UnconfiguredPrograms` are discarded. `cabal-install` resolves this by adding back the relevant `UnconfiguredPrograms` in `compilerProgramDb`. The cause of the bug was the order programs were added back. I have clarified the logic of the function now to: 1. Add back all unconfigured programs, and handle an explicit ghc-pkg path. 2. Then configure ghc-pkg and check it's the right version. This makes sure that the user-supplied path is honoured in both situations. Fixes #11373
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch master (beba231), #11450 and #11386 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #11386.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:#approved-reviews-by >= 2[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]#review-threads-unresolved = 0[🛡 GitHub branch protection]check-success = Doctest Cabalcheck-neutral = Doctest Cabalcheck-skipped = Doctest Cabalcheck-success = Meta checkscheck-neutral = Meta checkscheck-skipped = Meta checkscheck-success = docs/readthedocs.org:cabalcheck-neutral = docs/readthedocs.org:cabalcheck-skipped = docs/readthedocs.org:cabalcheck-success = Validate post jobcheck-neutral = Validate post jobcheck-skipped = Validate post jobcheck-success = fourmolucheck-neutral = fourmolucheck-skipped = fourmolucheck-success = hlintcheck-neutral = hlintcheck-skipped = hlintcheck-success = Bootstrap post jobcheck-neutral = Bootstrap post jobcheck-skipped = Bootstrap post jobcheck-success = whitespacecheck-neutral = whitespacecheck-skipped = whitespacecheck-success = Check sdist post jobcheck-neutral = Check sdist post jobcheck-skipped = Check sdist post jobcheck-success = Changelogscheck-neutral = Changelogscheck-skipped = ChangelogsRequired conditions to stay in the queue:
#approved-reviews-by >= 2[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]#review-threads-unresolved = 0[🛡 GitHub branch protection]check-success = Doctest Cabalcheck-neutral = Doctest Cabalcheck-skipped = Doctest Cabalcheck-success = Meta checkscheck-neutral = Meta checkscheck-skipped = Meta checkscheck-success = docs/readthedocs.org:cabalcheck-neutral = docs/readthedocs.org:cabalcheck-skipped = docs/readthedocs.org:cabalcheck-success = Validate post jobcheck-neutral = Validate post jobcheck-skipped = Validate post jobcheck-success = fourmolucheck-neutral = fourmolucheck-skipped = fourmolucheck-success = hlintcheck-neutral = hlintcheck-skipped = hlintcheck-success = Bootstrap post jobcheck-neutral = Bootstrap post jobcheck-skipped = Bootstrap post jobcheck-success = whitespacecheck-neutral = whitespacecheck-skipped = whitespacecheck-success = Check sdist post jobcheck-neutral = Check sdist post jobcheck-skipped = Check sdist post jobcheck-success = Changelogscheck-neutral = Changelogscheck-skipped = Changelogs