Skip to content

Update Cabal{,-install,-syntax} to 3.10.2.0 #9033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 23, 2023
Merged

Update Cabal{,-install,-syntax} to 3.10.2.0 #9033

merged 7 commits into from
Jun 23, 2023

Conversation

Kleidukos
Copy link
Member

@Kleidukos Kleidukos commented Jun 17, 2023 •
edited by Mikolaj
Loading

See #9008

@Kleidukos Kleidukos mentioned this pull request Jun 17, 2023
Closed
2 tasks
@Kleidukos Kleidukos requested a review from ffaf1 June 17, 2023 13:42
ulysses4ever
ulysses4ever approved these changes Jun 17, 2023
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, cabal-install-solver will lag behind the rest of the crew? (i.e. stay on 3.10.1)

ffaf1
ffaf1 approved these changes Jun 17, 2023
View reviewed changes
Copy link
Collaborator

@ffaf1 ffaf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☑

@Kleidukos Kleidukos added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Jun 17, 2023
@Kleidukos
Copy link
Member Author

@ulysses4ever we are not releasing any patch to it, so I don't see it as lagging, more as "was perfect since the beginning" :)

@Kleidukos Kleidukos force-pushed the bump-version-3.10.2.0 branch 2 times, most recently from 1355f77 to 750b420 Compare June 17, 2023 19:28
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jun 19, 2023
@ulysses4ever
Copy link
Collaborator

CI is stuck with some trouble about version number bump...

@Kleidukos
Copy link
Member Author

@ulysses4ever yeah actually I'm a bit worried about that one, I cannot manage to find the version bound that messes up :/

@ulysses4ever
Copy link
Collaborator

@Kleidukos I looked into it: if you bump the host version of cabal-install to 3.10.1, it works fine.

@ulysses4ever
Copy link
Collaborator

I went ahead and added a commit doing the bump. Let's see how far it gets...

@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Jun 20, 2023 •
edited
Loading

It passes Linux fully now but fails on Windows probably as in 420ccd8 Too bad we didn't get around to nailing 9.6.1 for 3.10

@ulysses4ever
Copy link
Collaborator

I'm slowly working through tests that are failing on Windows with the GHC and cabal bumps you already made. Those tests were handled (well, blocked) on master in the past. So far so good.

I also tried to add GHC 9.6.2 on CI and so far it worked on Linux.

@ulysses4ever ulysses4ever force-pushed the bump-version-3.10.2.0 branch from c68ad46 to 9c1aa71 Compare June 20, 2023 22:45
@ulysses4ever
Copy link
Collaborator

All right, adding 9.6 was a stretch, perhaps: I'm seeing strange testsuite failures on Windows. I'm striking that commit for the time being.

@ulysses4ever ulysses4ever force-pushed the bump-version-3.10.2.0 branch 2 times, most recently from 731e447 to 07a1a61 Compare June 21, 2023 13:23
@ulysses4ever
Copy link
Collaborator

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023

rebase

✅ Branch has been successfully rebased

@ulysses4ever ulysses4ever force-pushed the bump-version-3.10.2.0 branch from 07a1a61 to 74f21bd Compare June 21, 2023 15:55
@ulysses4ever
Copy link
Collaborator

Anyone knows how to cure stuck bootstrap jobs? I see them regularly but I never mastered this skill...

@Mikolaj
Copy link
Member

Mikolaj commented Jun 22, 2023

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Jun 22, 2023

refresh

✅ Pull request refreshed

@Mikolaj Mikolaj removed the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jun 22, 2023
@Mikolaj
Copy link
Member

Mikolaj commented Jun 22, 2023

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Jun 22, 2023

refresh

✅ Pull request refreshed

@Mikolaj Mikolaj added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jun 22, 2023
@Mikolaj
Copy link
Member

Mikolaj commented Jun 22, 2023

I have to fake it as a backport to get mergify to merge it.

@Mikolaj
Copy link
Member

Mikolaj commented Jun 22, 2023

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Jun 22, 2023

refresh

✅ Pull request refreshed

@Mikolaj Mikolaj changed the title Update Cabal{,-install,-syntax} to 3.10.2.0 Update Cabal{,-install,-syntax} to 3.10.2.0 (backport) Jun 22, 2023
@Mikolaj
Copy link
Member

Mikolaj commented Jun 22, 2023

Doh, I give up.

@Mikolaj Mikolaj changed the title Update Cabal{,-install,-syntax} to 3.10.2.0 (backport) Update Cabal{,-install,-syntax} to 3.10.2.0 Jun 22, 2023
@Mikolaj Mikolaj removed the backport label Jun 22, 2023
@ulysses4ever
Copy link
Collaborator

Green now!

@ulysses4ever
Copy link
Collaborator

We don't have Mergify rules for non-master branches (except backports), so someone has to push the button. @Kleidukos whenever you're ready...

@Kleidukos Kleidukos merged commit 14f66da into haskell:3.10 Jun 23, 2023
@Kleidukos Kleidukos deleted the bump-version-3.10.2.0 branch June 23, 2023 12:38
@Kleidukos
Copy link
Member Author

Thanks a bunch @ulysses4ever

@Mikolaj Mikolaj mentioned this pull request Aug 25, 2023
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@ffaf1 ffaf1 ffaf1 approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kleidukos @ulysses4ever @Mikolaj @ffaf1