Skip to content

feat: ghc 9.12.2, cabal 3.14.1.1 and stack 3.1.1 on bookworm #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 7, 2025

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented Apr 5, 2025

There's a question of what do do with all those buster images (since buster is long past the end of life).
For now I commented them out in CI config.
But I think we could even remove all of them from the repo. WDYT @develop7 ?

This PR aims to supersede #145

@jhrcek jhrcek requested a review from Copilot April 5, 2025 12:54
@jhrcek jhrcek marked this pull request as draft April 5, 2025 12:54
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.

Files not reviewed (2)
  • 9.12/bookworm/Dockerfile: Language not supported
  • 9.12/slim-bookworm/Dockerfile: Language not supported

@jhrcek jhrcek changed the title Add (slim-)bookworm images with ghc 9.12.2, cabal 3.14.1.1 and stac 3.1.1 Add (slim-)bookworm images for ghc 9.12.2, cabal 3.14.1.1, stack 3.1.1 Apr 5, 2025
@jhrcek jhrcek requested a review from Copilot April 5, 2025 13:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • 9.12/bookworm/Dockerfile: Language not supported
  • 9.12/slim-bookworm/Dockerfile: Language not supported

@jhrcek jhrcek marked this pull request as ready for review April 5, 2025 14:38
@jhrcek jhrcek requested a review from develop7 April 5, 2025 14:38
Copy link
Collaborator

@develop7 develop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While 9.12 is more than welcome, phasing buster out of CI doesn't belong this PR IMO. Could you move it elsewhere first?

@jhrcek jhrcek changed the title Add (slim-)bookworm images for ghc 9.12.2, cabal 3.14.1.1, stack 3.1.1 feat: ghc 9.12.2, cabal 3.14.1.1 and stack 3.1.1 on bookworm Apr 5, 2025
@jhrcek
Copy link
Collaborator Author

jhrcek commented Apr 5, 2025

@develop7 you're right. I removed all unrelated CI changes from this PR.
I commented out the buster stuff out of frustration because I didn't understand where the failing jobs are coming from.
(It was because I was missing the exclusions for 9.12 which doesn't have buster/bullseye variants.)

But in general are you in favor of both removing buster from CI as well as removing all buster dockerfiles from the repo in separate PR?
My arguments for removal: 1. don't waste CI resources building something that's past the EOL. 2. make the repo easier to navigate 3. if anyone wants those buster dockerfiles they can find them in git history.

@jhrcek jhrcek requested a review from develop7 April 5, 2025 16:41
Copy link
Collaborator

@develop7 develop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ship it

@jhrcek jhrcek merged commit 32ea631 into master Apr 7, 2025
31 checks passed
@jhrcek jhrcek mentioned this pull request Apr 7, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants