-
Notifications
You must be signed in to change notification settings - Fork 37
feat: ghc 9.12.2, cabal 3.14.1.1 and stack 3.1.1 on bookworm #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.
Files not reviewed (2)
- 9.12/bookworm/Dockerfile: Language not supported
- 9.12/slim-bookworm/Dockerfile: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (2)
- 9.12/bookworm/Dockerfile: Language not supported
- 9.12/slim-bookworm/Dockerfile: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While 9.12 is more than welcome, phasing buster out of CI doesn't belong this PR IMO. Could you move it elsewhere first?
@develop7 you're right. I removed all unrelated CI changes from this PR. But in general are you in favor of both removing buster from CI as well as removing all buster dockerfiles from the repo in separate PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ship it
There's a question of what do do with all those buster images (since buster is long past the end of life).
For now I commented them out in CI config.
But I think we could even remove all of them from the repo. WDYT @develop7 ?
This PR aims to supersede #145